Pass JavaRef to Java methods in device/bluetooth.

device/bluetooth/bluetooth_remote_gatt_service_android.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_remote_gatt_service_android.h"
 
 #include <memory>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "device/bluetooth/bluetooth_adapter_android.h"
 #include "device/bluetooth/bluetooth_device_android.h"
 #include "device/bluetooth/bluetooth_remote_gatt_characteristic_android.h"
 #include "jni/ChromeBluetoothRemoteGattService_jni.h"
 
 using base::android::AttachCurrentThread;
 using base::android::JavaParamRef;
+using base::android::JavaRef;
 
 namespace device {
 
 // static
 std::unique_ptr<BluetoothRemoteGattServiceAndroid>
 BluetoothRemoteGattServiceAndroid::Create(
     BluetoothAdapterAndroid* adapter,
     BluetoothDeviceAndroid* device,
-    jobject /* BluetoothGattServiceWrapper */ bluetooth_gatt_service_wrapper,
+    const JavaRef<
+        jobject>& /* BluetoothGattServiceWrapper */ bluetooth_gatt_service_wrapper,

[Torne, 2016/09/07 16:50:50]

This line and others like it in the change end up blowing the 80 char limit,
because clang-format isn't willing to split the comment apart from the type and
variable name. Are these comments actually useful? The parameters all seem to be
named the exact same thing as the type anyway - removing the comments would make
this code much easier to format sensibly..

[scheib, 2016/09/07 18:00:30]

I believe clang format will be happier if the comments change to // single lines
- it will respect the line breaks.

The comments were added early on at some reviewers requests to keep track of the
data types -- though I agree that the names match the data types, it's still
hard to know what java object the thing is supposed to be. jobject is rather
like passing around a lot of void*s, and to C++ programmers it feels odd.

     const std::string& instance_id,
-    jobject /* ChromeBluetoothDevice */ chrome_bluetooth_device) {
+    const JavaRef<
+        jobject>& /* ChromeBluetoothDevice */ chrome_bluetooth_device) {
   std::unique_ptr<BluetoothRemoteGattServiceAndroid> service(
       new BluetoothRemoteGattServiceAndroid(adapter, device, instance_id));
 
   JNIEnv* env = AttachCurrentThread();
   service->j_service_.Reset(Java_ChromeBluetoothRemoteGattService_create(
       env, reinterpret_cast<intptr_t>(service.get()),
       bluetooth_gatt_service_wrapper,
       base::android::ConvertUTF8ToJavaString(env, instance_id),
       chrome_bluetooth_device));
 
@@ skipping 143 matching lines @@
 void BluetoothRemoteGattServiceAndroid::EnsureCharacteristicsCreated() const {
   if (!characteristics_.empty())
     return;
 
   // Java call
   Java_ChromeBluetoothRemoteGattService_createCharacteristics(
       AttachCurrentThread(), j_service_);
 }
 
 }  // namespace device