Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2313393002: Revert of Remove the top-level GYP files (or stub them out). (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw, Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the top-level GYP files (or stub them out). (patchset #2 id:20001 of https://codereview.chromium.org/2299543008/ ) Reason for revert: broke the closure_compilation builders. Original issue's description: > Remove the top-level GYP files (or stub them out). > > GYP is now thoroughly broken, and it's safe to remove the top-level > files, except where gyp_chromium is still needed for the hooks run > by gclient (to pick up and process GYP_DEFINES). > > R=brettw@chromium.org > BUG= > > Committed: https://crrev.com/6ca365af92a486150c8f01b1aca2557a6fa504f1 > Cr-Commit-Position: refs/heads/master@{#416782} TBR=brettw@chromium.org,dbeam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7e86569476a1fee9666d0c4a56099525c9977c87 Cr-Commit-Position: refs/heads/master@{#416962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8849 lines, -6 lines) Patch
A build/PRESUBMIT.py View 1 chunk +16 lines, -0 lines 0 comments Download
A build/all.gyp View 1 chunk +1342 lines, -0 lines 0 comments Download
A build/common.gypi View 1 chunk +6348 lines, -0 lines 0 comments Download
A build/gn_migration.gypi View 1 chunk +763 lines, -0 lines 0 comments Download
A build/gyp_chromium View 1 chunk +12 lines, -0 lines 0 comments Download
M build/gyp_chromium.py View 2 chunks +280 lines, -6 lines 0 comments Download
A build/gyp_chromium_test.py View 1 chunk +64 lines, -0 lines 0 comments Download
A build/some.gyp View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
Created Revert of Remove the top-level GYP files (or stub them out).
4 years, 3 months ago (2016-09-07 16:37:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313393002/1
4 years, 3 months ago (2016-09-07 16:38:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 16:40:26 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 16:43:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e86569476a1fee9666d0c4a56099525c9977c87
Cr-Commit-Position: refs/heads/master@{#416962}

Powered by Google App Engine
This is Rietveld 408576698