Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 2313353003: Ozone/Wayland: Move to newer APIs and improve GPU initialization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 1 week ago by fwang
Modified:
11 months, 1 week ago
Reviewers:
rjkroege
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, spang, kylechar, not to use - tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone/Wayland: Move to newer APIs and improve GPU initialization The Wayland platform for Ozone currently implements the following deprecated API from SurfaceOzoneCanvas: * CreateViewGLSurface * CreateOffscreenGLSurface * GetNativeDisplay * LoadEGLGLES2Bindings That code is moved into a separate GLOzoneEGLWayland helper class implementing GLOzoneEGL. This also allows to better handle the fact that the support is restricted to the kGLImplementationEGLGLES2 implementation. Also OzonePlatformWayland is updated to prepare support for the newer variants of InitializeForUI and InitializeGPU with initialization parameters, even if every callers do not set these parameters correctly at the moment. Currently, InitializeGPU checks whether surface_factory_ has been initialized and otherwise creates a WaylandSurfaceFactory with a null Wayland connection. Some comments are added to clarify these two workarounds. In particular, the verification could be made clearer with args.single_process when the migration to the new InitializeGPU variant is complete. Additional changes better protect the part of WaylandSurfaceFactory that assumes a non-null Wayland connection and ensure that we always fullfill this assumption inside the WaylandSurfaceFactory and WaylandCanvasSurface helper classes. R=rjkroege@chromium.org BUG=none Committed: https://crrev.com/4573447ff7ea84bac0572d4a4aa5b371852285c1 Cr-Commit-Position: refs/heads/master@{#417528}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
rjkroege
Thanks. lgtm.
11 months, 1 week ago (2016-09-08 22:47:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313353003/1
11 months, 1 week ago (2016-09-09 07:02:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
11 months, 1 week ago (2016-09-09 07:40:15 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4573447ff7ea84bac0572d4a4aa5b371852285c1 Cr-Commit-Position: refs/heads/master@{#417528}
11 months, 1 week ago (2016-09-09 07:41:42 UTC) #11
fwang
11 months, 1 week ago (2016-09-09 07:48:47 UTC) #12
Message was sent while issue was closed.
For the record, the GLOzone interface interface was introduced in
https://codereview.chromium.org/2270463002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b