Ozone/Wayland: Move to newer APIs and improve GPU initialization

Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=rjkroege@chromium.org
BUG=none

Committed: https://crrev.com/4573447ff7ea84bac0572d4a4aa5b371852285c1
Cr-Commit-Position: refs/heads/master@{#417528}

[fwang, 2016-09-08 09:18:13]

Description was changed from

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=foo@chromium.org
BUG=none
==========

to

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=foo@chromium.org
BUG=none
==========

[fwang, 2016-09-08 09:18:13]

fwang@igalia.com changed reviewers:
+ rjkroege@chromium.org
- foo@chromium.org

[fwang, 2016-09-08 09:18:59]

Description was changed from

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=foo@chromium.org
BUG=none
==========

to

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=rjkroege@chromium.org
BUG=none
==========

[rjkroege, 2016-09-08 22:47:14]

Thanks. lgtm.

[fwang, 2016-09-09 07:01:56]

The CQ bit was checked by fwang@igalia.com

[commit-bot: I haz the power, 2016-09-09 07:02:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fwang, 2016-09-09 07:38:34]

Description was changed from

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=rjkroege@chromium.org
BUG=none
==========

to

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=rjkroege@chromium.org
BUG=none
==========

[commit-bot: I haz the power, 2016-09-09 07:40:14]

Description was changed from

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=rjkroege@chromium.org
BUG=none
==========

to

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=rjkroege@chromium.org
BUG=none
==========

[commit-bot: I haz the power, 2016-09-09 07:40:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-09 07:41:41]

Description was changed from

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=rjkroege@chromium.org
BUG=none
==========

to

==========
Ozone/Wayland: Move to newer APIs and improve GPU initialization

The Wayland platform for Ozone currently implements the following
deprecated API from SurfaceOzoneCanvas:

* CreateViewGLSurface
* CreateOffscreenGLSurface
* GetNativeDisplay
* LoadEGLGLES2Bindings

That code is moved into a separate GLOzoneEGLWayland helper class
implementing GLOzoneEGL. This also allows to better handle the fact that
the support is restricted to the kGLImplementationEGLGLES2
implementation.

Also OzonePlatformWayland is updated to prepare support for the newer
variants of InitializeForUI and InitializeGPU with initialization
parameters, even if every callers do not set these parameters correctly
at the moment.

Currently, InitializeGPU checks whether surface_factory_ has been
initialized and otherwise creates a WaylandSurfaceFactory with a null
Wayland connection. Some comments are added to clarify these two
workarounds. In particular, the verification could be made clearer with
args.single_process when the migration to the new InitializeGPU variant
is complete. Additional changes better protect the part of
WaylandSurfaceFactory that assumes a non-null Wayland connection and
ensure that we always fullfill this assumption inside the
WaylandSurfaceFactory and WaylandCanvasSurface helper classes.

R=rjkroege@chromium.org
BUG=none

Committed: https://crrev.com/4573447ff7ea84bac0572d4a4aa5b371852285c1
Cr-Commit-Position: refs/heads/master@{#417528}
==========

[commit-bot: I haz the power, 2016-09-09 07:41:42]

Patchset 1 (id:??) landed as
https://crrev.com/4573447ff7ea84bac0572d4a4aa5b371852285c1
Cr-Commit-Position: refs/heads/master@{#417528}

[fwang, 2016-09-09 07:48:47]

For the record, the GLOzone interface interface was introduced in
https://codereview.chromium.org/2270463002