Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issue 231333003: Prevent fling gesture if most recent touch move was consumed. (Closed)

Created:
6 years, 8 months ago by tdresser
Modified:
6 years, 8 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Prevent fling gesture if most recent touch move was consumed. BUG=361685 TEST=TouchDispositionFilterTest.ConsumedScrollUpdateMakesFlingScrollEnd Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262823

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address jdduke comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc View 1 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tdresser
PTAL, thanks.
6 years, 8 months ago (2014-04-09 18:16:49 UTC) #1
jdduke (slow)
lgtm https://codereview.chromium.org/231333003/diff/1/ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc File ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc (right): https://codereview.chromium.org/231333003/diff/1/ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc#newcode887 ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc:887: PushGesture(ET_SCROLL_FLING_CANCEL); I'm not aware of any legitimate cases ...
6 years, 8 months ago (2014-04-09 18:25:45 UTC) #2
tdresser
Thanks for the speedy review. https://codereview.chromium.org/231333003/diff/1/ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc File ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc (right): https://codereview.chromium.org/231333003/diff/1/ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc#newcode893 ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc:893: } On 2014/04/09 18:25:45, ...
6 years, 8 months ago (2014-04-09 18:33:19 UTC) #3
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 8 months ago (2014-04-09 18:33:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/231333003/20001
6 years, 8 months ago (2014-04-09 18:34:22 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 21:33:52 UTC) #6
Message was sent while issue was closed.
Change committed as 262823

Powered by Google App Engine
This is Rietveld 408576698