ui/events/gesture_detection/touch_disposition_gesture_filter.cc - Issue 231333003: Prevent fling gesture if most recent touch move was consumed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/touch_disposition_gesture_filter.cc

Issue 231333003: Prevent fling gesture if most recent touch move was consumed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address jdduke comments. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/gesture_detection/touch_disposition_gesture_filter.cc

diff --git a/ui/events/gesture_detection/touch_disposition_gesture_filter.cc b/ui/events/gesture_detection/touch_disposition_gesture_filter.cc

index 6f405e58f96faa00f18fbe1fe1c62c8ae17bcbf5..bf1d8c320abc89764062ec83ff5f67b352f93526 100644

--- a/ui/events/gesture_detection/touch_disposition_gesture_filter.cc

+++ b/ui/events/gesture_detection/touch_disposition_gesture_filter.cc

@@ -79,7 +79,9 @@ DispositionHandlingInfo GetDispositionHandlingInfo(EventType type) {

case ET_GESTURE_SCROLL_END:

return Info(RT_NONE, ET_GESTURE_SCROLL_BEGIN);

case ET_SCROLL_FLING_START:

- return Info(RT_NONE, ET_GESTURE_SCROLL_BEGIN);

+ // We rely on |EndScrollGestureIfNecessary| to end the scroll if the fling

+ // start is prevented.

+ return Info(RT_NONE, ET_GESTURE_SCROLL_UPDATE);

case ET_SCROLL_FLING_CANCEL:

return Info(RT_NONE, ET_SCROLL_FLING_START);

case ET_GESTURE_PINCH_BEGIN:

« no previous file with comments | « no previous file | ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc » ('j') | no next file with comments »