Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2313293002: [SubZero] Implement address optimization for MIPS (Closed)

Created:
4 years, 3 months ago by jaydeep.patil
Modified:
4 years, 3 months ago
Reviewers:
Karl, John, sagar.thakur, Jim Stichnoth, srdjan.obucina, Eric Holk
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[SubZero] Implement address optimization for MIPS The patch implements address optimization for MIPS. R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=47ef0be853cfd485967327aa7f9c67a747a657d8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -2 lines) Patch
M src/IceTargetLoweringMIPS32.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 1 2 chunks +239 lines, -2 lines 0 comments Download
A tests_lit/llvm2ice_tests/mips-address-mode-opt.ll View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jaydeep.patil
4 years, 3 months ago (2016-09-07 12:33:48 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/2313293002/diff/1/src/IceTargetLoweringMIPS32.cpp File src/IceTargetLoweringMIPS32.cpp (right): https://codereview.chromium.org/2313293002/diff/1/src/IceTargetLoweringMIPS32.cpp#newcode2345 src/IceTargetLoweringMIPS32.cpp:2345: const bool IsSingleBB = (DefNode->getIndex() == UseNode->getIndex()); Why are ...
4 years, 3 months ago (2016-09-09 00:08:22 UTC) #4
jaydeep.patil
https://codereview.chromium.org/2313293002/diff/1/src/IceTargetLoweringMIPS32.cpp File src/IceTargetLoweringMIPS32.cpp (right): https://codereview.chromium.org/2313293002/diff/1/src/IceTargetLoweringMIPS32.cpp#newcode2345 src/IceTargetLoweringMIPS32.cpp:2345: const bool IsSingleBB = (DefNode->getIndex() == UseNode->getIndex()); On 2016/09/09 ...
4 years, 3 months ago (2016-09-13 06:42:25 UTC) #5
jaydeep.patil
4 years, 3 months ago (2016-09-13 06:44:09 UTC) #6
Jim Stichnoth
lgtm
4 years, 3 months ago (2016-09-13 13:09:36 UTC) #7
Jim Stichnoth
4 years, 3 months ago (2016-09-13 13:09:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
47ef0be853cfd485967327aa7f9c67a747a657d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698