Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2313253002: Move HTMLDocument::isCaseSensitiveAttribute into SelectorChecker (Closed)

Created:
4 years, 3 months ago by foolip
Modified:
4 years, 3 months ago
Reviewers:
esprehn, rune
CC:
chromium-reviews, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move HTMLDocument::isCaseSensitiveAttribute into SelectorChecker BUG=238368 R=esprehn@chromium.org,rune@opera.com Committed: https://crrev.com/e912108e9daf83d1bec61e5b78aaacf965a3e2fc Cr-Commit-Position: refs/heads/master@{#416903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -42 lines) Patch
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 2 chunks +40 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDocument.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDocument.cpp View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
foolip
4 years, 3 months ago (2016-09-07 08:13:49 UTC) #1
rune
lgtm
4 years, 3 months ago (2016-09-07 08:25:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313253002/1
4 years, 3 months ago (2016-09-07 10:56:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 11:00:30 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e912108e9daf83d1bec61e5b78aaacf965a3e2fc Cr-Commit-Position: refs/heads/master@{#416903}
4 years, 3 months ago (2016-09-07 11:02:19 UTC) #11
foolip
4 years, 3 months ago (2016-09-09 11:43:18 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2326493004/ by foolip@chromium.org.

The reason for reverting is: Possible cause of regression in blink_perf.parser.

BUG=645370.

Powered by Google App Engine
This is Rietveld 408576698