Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2313243002: Reland of "[heap] Switch to 500k pages" (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[heap] Switch to 500k pages" This reverts commit 332bd5e94c7b70d1d74d6ce1e9f86fee278740f6. BUG=chromium:636331 R=ulan@chromium.org Committed: https://crrev.com/79faa52823ac7ce8530846f698e707505681f597 Cr-Commit-Position: refs/heads/master@{#39237}

Patch Set 1 : base (breaking arm64 debug nosnap) #

Patch Set 2 : Test fixes (general fixes are in dependent CL) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M src/base/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/heap/test-page-promotion.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/test-strings.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Michael Lippautz
ptal General test fixes are in https://codereview.chromium.org/2313273002#ps1 to make sure they land in case this ...
4 years, 3 months ago (2016-09-07 09:04:49 UTC) #4
ulan
lgtm
4 years, 3 months ago (2016-09-07 09:17:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313243002/40001
4 years, 3 months ago (2016-09-07 09:41:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-07 09:43:19 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 09:43:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/79faa52823ac7ce8530846f698e707505681f597
Cr-Commit-Position: refs/heads/master@{#39237}

Powered by Google App Engine
This is Rietveld 408576698