Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: test/cctest/heap/test-page-promotion.cc

Issue 2313243002: Reland of "[heap] Switch to 500k pages" (Closed)
Patch Set: Test fixes (general fixes are in dependent CL) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/heap/test-heap.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-page-promotion.cc
diff --git a/test/cctest/heap/test-page-promotion.cc b/test/cctest/heap/test-page-promotion.cc
index a42e315a1c0959c7cd01f006bd74a21907b2feae..ccb3691e34d66fade85c646d6248d48ba96a6fdf 100644
--- a/test/cctest/heap/test-page-promotion.cc
+++ b/test/cctest/heap/test-page-promotion.cc
@@ -21,7 +21,7 @@ namespace {
v8::Isolate* NewIsolateForPagePromotion() {
i::FLAG_page_promotion = true;
i::FLAG_page_promotion_threshold = 0; // %
- i::FLAG_min_semi_space_size = 8 * (i::Page::kPageSize / i::MB);
+ i::FLAG_min_semi_space_size = 8;
// We cannot optimize for size as we require a new space with more than one
// page.
i::FLAG_optimize_for_size = false;
@@ -109,7 +109,6 @@ UNINITIALIZED_TEST(PagePromotion_NewToNewJSArrayBuffer) {
// Fill the current page which potentially contains the age mark.
heap::FillCurrentPage(heap->new_space());
-
// Allocate a buffer we would like to check against.
Handle<JSArrayBuffer> buffer =
i_isolate->factory()->NewJSArrayBuffer(SharedFlag::kNotShared);
« no previous file with comments | « test/cctest/heap/test-heap.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698