Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 2313143002: Revert of Disabling v8.todoMVC tests on reference builds (Closed)

Created:
4 years, 3 months ago by lpy
Modified:
4 years, 3 months ago
Reviewers:
picksi, nednguyen, Sami, picksi1
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disabling v8.todoMVC tests on reference builds (patchset #1 id:1 of https://codereview.chromium.org/2304113002/ ) Reason for revert: Enable v8.todoMVC tests on reference builds since they won't fail on TOT now. Original issue's description: > Disabling v8.todoMVC tests on reference builds > > BUG=636405 > NOTRY=true > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > Committed: https://crrev.com/0de9faf1af255a6e7d928ee4c65eb0214ce72a3e > Cr-Commit-Position: refs/heads/master@{#416270} TBR=skyostil@chromium.org,picksi@chromium.org,picksi@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636405 Committed: https://crrev.com/be74d8bad819ed4753b82f03003e8d88b1816ed0 Cr-Commit-Position: refs/heads/master@{#416806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tools/perf/benchmarks/v8.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
lpy
Created Revert of Disabling v8.todoMVC tests on reference builds
4 years, 3 months ago (2016-09-06 22:57:11 UTC) #1
lpy
Ned, could you please take a look?
4 years, 3 months ago (2016-09-06 22:58:16 UTC) #3
nednguyen
lgtm
4 years, 3 months ago (2016-09-06 22:58:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313143002/1
4 years, 3 months ago (2016-09-06 23:01:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 00:54:02 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 00:55:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be74d8bad819ed4753b82f03003e8d88b1816ed0
Cr-Commit-Position: refs/heads/master@{#416806}

Powered by Google App Engine
This is Rietveld 408576698