Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 2313143002: Revert of Disabling v8.todoMVC tests on reference builds (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import re 5 import re
6 6
7 from core import path_util 7 from core import path_util
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from page_sets import google_pages 9 from page_sets import google_pages
10 10
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 return options 110 return options
111 111
112 @classmethod 112 @classmethod
113 def ValueCanBeAddedPredicate(cls, value, _): 113 def ValueCanBeAddedPredicate(cls, value, _):
114 return 'v8' in value.name 114 return 'v8' in value.name
115 115
116 @classmethod 116 @classmethod
117 def ShouldTearDownStateAfterEachStoryRun(cls): 117 def ShouldTearDownStateAfterEachStoryRun(cls):
118 return True 118 return True
119 119
120 # Disabled on reference builds as they are failing across multiple Android 120
121 # devices. see http://crbug.com/636405
122 @benchmark.Disabled('reference')
123 class V8TodoMVC(perf_benchmark.PerfBenchmark): 121 class V8TodoMVC(perf_benchmark.PerfBenchmark):
124 """Measures V8 Execution metrics on the TodoMVC examples.""" 122 """Measures V8 Execution metrics on the TodoMVC examples."""
125 page_set = page_sets.TodoMVCPageSet 123 page_set = page_sets.TodoMVCPageSet
126 124
127 def CreateTimelineBasedMeasurementOptions(self): 125 def CreateTimelineBasedMeasurementOptions(self):
128 return CreateV8TimelineBasedMeasurementOptions() 126 return CreateV8TimelineBasedMeasurementOptions()
129 127
130 @classmethod 128 @classmethod
131 def Name(cls): 129 def Name(cls):
132 return 'v8.todomvc' 130 return 'v8.todomvc'
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 return True 312 return True
315 # http://crbug.com/623576 313 # http://crbug.com/623576
316 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or 314 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or
317 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'): 315 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'):
318 return True 316 return True
319 return False 317 return False
320 318
321 @classmethod 319 @classmethod
322 def ShouldTearDownStateAfterEachStoryRun(cls): 320 def ShouldTearDownStateAfterEachStoryRun(cls):
323 return True 321 return True
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698