Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2313113002: [Mac][Material Design] Adjust focus ring position of bookmark bar items. (Closed)

Created:
4 years, 3 months ago by shrike
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Adjust focus ring position of bookmark bar items. This cl fixes a regression caused by a recent cl that adjusted bookmark bar item metrics. Those changes threw off the positioning of the focus ring highlights. R=avi@chromium.org BUG=640106 Review-Url: https://codereview.chromium.org/2299803003 Cr-Commit-Position: refs/heads/master@{#416018} (cherry picked from commit ee1b55d9a6b0dfb066bab62ec24a1357a8794cde) Committed: https://chromium.googlesource.com/chromium/src/+/b94adffc1bedcf86fc375c18d233d5b9f3a1ea29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
shrike
Committed patchset #1 (id:1) manually as b94adffc1bedcf86fc375c18d233d5b9f3a1ea29 (tree was closed).
4 years, 3 months ago (2016-09-06 22:40:17 UTC) #2
Avi (use Gerrit)
4 years, 3 months ago (2016-09-07 02:52:50 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698