Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2299803003: [Mac][Material Design] Adjust focus ring position of bookmark bar items. (Closed)

Created:
4 years, 3 months ago by shrike
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Adjust focus ring position of bookmark bar items. This cl fixes a regression caused by a recent cl that adjusted bookmark bar item metrics. Those changes threw off the positioning of the focus ring highlights. R=avi@chromium.org BUG=640106 Committed: https://crrev.com/ee1b55d9a6b0dfb066bab62ec24a1357a8794cde Cr-Commit-Position: refs/heads/master@{#416018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 3 months ago (2016-09-01 18:30:09 UTC) #1
Avi (use Gerrit)
lgtm stamp
4 years, 3 months ago (2016-09-01 18:42:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299803003/1
4 years, 3 months ago (2016-09-01 18:45:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 19:39:20 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 19:42:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee1b55d9a6b0dfb066bab62ec24a1357a8794cde
Cr-Commit-Position: refs/heads/master@{#416018}

Powered by Google App Engine
This is Rietveld 408576698