Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2313013002: Revert of Adjust callers and networking delegates in net/ to modified APIs (Closed)

Created:
4 years, 3 months ago by mmenke
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@URLRequestRead
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adjust callers and networking delegates in net/ to modified APIs (patchset #6 id:460001 of https://codereview.chromium.org/2265873002/ ) Reason for revert: This appears to have made Android bots flaky. Original issue's description: > Adjust callers and networking delegates in net/ to modified APIs > > Use modified Read and delegate methods from the following CL- > https://codereview.chromium.org/2262653003/ > > BUG=423484 > > Committed: https://crrev.com/65db2c48753ba5a516e9a4147f93a9c218d5f76e > Cr-Commit-Position: refs/heads/master@{#416511} TBR=maksim.sisov@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=423484 Committed: https://crrev.com/fe5d0b1104e315059b125a981361fc88ee2e2541 Cr-Commit-Position: refs/heads/master@{#416719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -357 lines) Patch
M net/cert_net/cert_net_fetcher_impl.cc View 12 chunks +48 lines, -42 lines 0 comments Download
M net/cert_net/nss_ocsp.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M net/nqe/network_quality_estimator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M net/nqe/throughput_analyzer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/network_delegate_error_observer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 5 chunks +14 lines, -21 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/spawner_communicator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/spawner_communicator.cc View 6 chunks +23 lines, -32 lines 0 comments Download
M net/url_request/report_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/report_sender.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M net/url_request/sdch_dictionary_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/sdch_dictionary_fetcher.cc View 5 chunks +17 lines, -16 lines 0 comments Download
M net/url_request/url_fetcher_core.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_core.cc View 4 chunks +21 lines, -17 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_data_job_fuzzer.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M net/url_request/url_request_file_dir_job_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M net/url_request/url_request_ftp_job_unittest.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_request_http_job_unittest.cc View 14 chunks +15 lines, -14 lines 0 comments Download
M net/url_request/url_request_job_factory_impl_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request_simple_job_unittest.cc View 8 chunks +13 lines, -7 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 98 chunks +168 lines, -117 lines 0 comments Download
M net/websockets/websocket_end_to_end_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_stream.cc View 5 chunks +22 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mmenke
Created Revert of Adjust callers and networking delegates in net/ to modified APIs
4 years, 3 months ago (2016-09-06 18:29:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313013002/1
4 years, 3 months ago (2016-09-06 18:29:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 20:47:23 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:48:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe5d0b1104e315059b125a981361fc88ee2e2541
Cr-Commit-Position: refs/heads/master@{#416719}

Powered by Google App Engine
This is Rietveld 408576698