Initialize RenderWidget(Host)(View)s with correct visibility state

content/browser/web_contents/render_view_host_manager.h

Index: content/browser/web_contents/render_view_host_manager.h
diff --git a/content/browser/web_contents/render_view_host_manager.h b/content/browser/web_contents/render_view_host_manager.h
index 8c5071d9d654d001c88c5ee35317d8f7c12c4916..4580e1c83bec12545b5f6a98415fbb0280e7b54f 100644
--- a/content/browser/web_contents/render_view_host_manager.h
+++ b/content/browser/web_contents/render_view_host_manager.h
@@ -117,7 +117,8 @@ class CONTENT_EXPORT RenderViewHostManager
   void Init(BrowserContext* browser_context,
             SiteInstance* site_instance,
             int routing_id,
-            int main_frame_routing_id);
+            int main_frame_routing_id,
+            bool hidden);
 
   // Returns the currently active RenderViewHost.
   //
@@ -150,7 +151,7 @@ class CONTENT_EXPORT RenderViewHostManager
   // navigation entry. It may create a new RenderViewHost or re-use an existing
   // one. The RenderViewHost to navigate will be returned. Returns NULL if one
   // could not be created.
-  RenderViewHostImpl* Navigate(const NavigationEntryImpl& entry);
+  RenderViewHostImpl* Navigate(const NavigationEntryImpl& entry, bool hidden);

[Charlie Reis, 2013/08/19 22:18:02]

I'd really like to avoid passing more parameters here and on
UpdateRendererStateForNavigate, especially non-navigation related ones.  Could
we add something like a IsHidden() method to RVHM::Delegate instead and pass
that into CreateRenderView?

(We already do a fair amount of state checking on the delegate_ in those
methods, so that wouldn't really be introducing a big dependency.)

[jamesr, 2013/08/19 23:50:39]

OK, done.  I have to call it in two places - when calling CreateRenderView() and
when creating the initial view in ::Init().  I think it's still OK.

 
   // Instructs the various live views to stop. Called when the user directed the
   // page to stop loading.
@@ -181,7 +182,8 @@ class CONTENT_EXPORT RenderViewHostManager
   // will be used for a pending cross-site navigation.
   int CreateRenderView(SiteInstance* instance,
                        int opener_route_id,
-                       bool swapped_out);
+                       bool swapped_out,
+                       bool hidden);
 
   // Called when a provisional load on the given renderer is aborted.
   void RendererAbortedProvisionalLoad(RenderViewHost* render_view_host);
@@ -290,7 +292,7 @@ class CONTENT_EXPORT RenderViewHostManager
   void CancelPending();
 
   RenderViewHostImpl* UpdateRendererStateForNavigate(
-      const NavigationEntryImpl& entry);
+      const NavigationEntryImpl& entry, bool hidden);

[sky, 2013/08/19 20:21:47]

nit: when you wrap one param per line.

 
   // Called when a renderer process is starting to close.  We should not
   // schedule new navigations in its swapped out RenderViewHosts after this.