Initialize RenderWidget(Host)(View)s with correct visibility state

content/browser/web_contents/render_view_host_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_RENDER_VIEW_HOST_MANAGER_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_RENDER_VIEW_HOST_MANAGER_H_
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 99 matching lines @@
   RenderViewHostManager(
       RenderViewHostDelegate* render_view_delegate,
       RenderWidgetHostDelegate* render_widget_delegate,
       Delegate* delegate);
   virtual ~RenderViewHostManager();
 
   // For arguments, see WebContentsImpl constructor.
   void Init(BrowserContext* browser_context,
             SiteInstance* site_instance,
             int routing_id,
-            int main_frame_routing_id);
+            int main_frame_routing_id,
+            bool hidden);
 
   // Returns the currently active RenderViewHost.
   //
   // This will be non-NULL between Init() and Shutdown(). You may want to NULL
   // check it in many cases, however. Windows can send us messages during the
   // destruction process after it has been shut down.
   RenderViewHostImpl* current_host() const;
 
   // Returns the view associated with the current RenderViewHost, or NULL if
   // there is no current one.
@@ skipping 12 matching lines @@
   }
 
   // Sets the pending Web UI for the pending navigation, ensuring that the
   // bindings are appropriate for the given NavigationEntry.
   void SetPendingWebUI(const NavigationEntryImpl& entry);
 
   // Called when we want to instruct the renderer to navigate to the given
   // navigation entry. It may create a new RenderViewHost or re-use an existing
   // one. The RenderViewHost to navigate will be returned. Returns NULL if one
   // could not be created.
-  RenderViewHostImpl* Navigate(const NavigationEntryImpl& entry);
+  RenderViewHostImpl* Navigate(const NavigationEntryImpl& entry, bool hidden);

[Charlie Reis, 2013/08/19 22:18:02]

I'd really like to avoid passing more parameters here and on
UpdateRendererStateForNavigate, especially non-navigation related ones.  Could
we add something like a IsHidden() method to RVHM::Delegate instead and pass
that into CreateRenderView?

(We already do a fair amount of state checking on the delegate_ in those
methods, so that wouldn't really be introducing a big dependency.)

[jamesr, 2013/08/19 23:50:39]

OK, done.  I have to call it in two places - when calling CreateRenderView() and
when creating the initial view in ::Init().  I think it's still OK.

 
   // Instructs the various live views to stop. Called when the user directed the
   // page to stop loading.
   void Stop();
 
   // Notifies the regular and pending RenderViewHosts that a load is or is not
   // happening. Even though the message is only for one of them, we don't know
   // which one so we tell both.
   void SetIsLoading(bool is_loading);
 
@@ skipping 10 matching lines @@
   void DidNavigateMainFrame(RenderViewHost* render_view_host);
 
   // Called when a renderer sets its opener to null.
   void DidDisownOpener(RenderViewHost* render_view_host);
 
   // Helper method to create a RenderViewHost.  If |swapped_out| is true, it
   // will be initially placed on the swapped out hosts list.  Otherwise, it
   // will be used for a pending cross-site navigation.
   int CreateRenderView(SiteInstance* instance,
                        int opener_route_id,
-                       bool swapped_out);
+                       bool swapped_out,
+                       bool hidden);
 
   // Called when a provisional load on the given renderer is aborted.
   void RendererAbortedProvisionalLoad(RenderViewHost* render_view_host);
 
   // Sets the passed passed interstitial as the currently showing interstitial.
   // |interstitial_page| should be non NULL (use the remove_interstitial_page
   // method to unset the interstitial) and no interstitial page should be set
   // when there is already a non NULL interstitial page set.
   void set_interstitial_page(InterstitialPageImpl* interstitial_page) {
     DCHECK(!interstitial_page_ && interstitial_page);
@@ skipping 88 matching lines @@
 
   // Shutdown all RenderViewHosts in a SiteInstance. This is called
   // to shutdown views when all the views in a SiteInstance are
   // confirmed to be swapped out.
   void ShutdownRenderViewHostsInSiteInstance(int32 site_instance_id);
 
   // Helper method to terminate the pending RenderViewHost.
   void CancelPending();
 
   RenderViewHostImpl* UpdateRendererStateForNavigate(
-      const NavigationEntryImpl& entry);
+      const NavigationEntryImpl& entry, bool hidden);

[sky, 2013/08/19 20:21:47]

nit: when you wrap one param per line.

 
   // Called when a renderer process is starting to close.  We should not
   // schedule new navigations in its swapped out RenderViewHosts after this.
   void RendererProcessClosing(RenderProcessHost* render_process_host);
 
   // Our delegate, not owned by us. Guaranteed non-NULL.
   Delegate* delegate_;
 
   // Whether a navigation requiring different RenderView's is pending. This is
   // either cross-site request is (in the new process model), or when required
@@ skipping 43 matching lines @@
   InterstitialPageImpl* interstitial_page_;
 
   NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_RENDER_VIEW_HOST_MANAGER_H_