Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5966)

Unified Diff: chrome/browser/sync/glue/generic_change_processor.h

Issue 23129007: sync: Add GetAllSyncData to sync/api (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/generic_change_processor.h
diff --git a/chrome/browser/sync/glue/generic_change_processor.h b/chrome/browser/sync/glue/generic_change_processor.h
index a987ebeb4a5993c14749b0edd876d95fd78f6101..a119a59500b489ee4c80293f02c8c1765034f778 100644
--- a/chrome/browser/sync/glue/generic_change_processor.h
+++ b/chrome/browser/sync/glue/generic_change_processor.h
@@ -62,10 +62,17 @@ class GenericChangeProcessor : public ChangeProcessor,
const tracked_objects::Location& from_here,
const syncer::SyncChangeList& change_list) OVERRIDE;
- // Fills |current_sync_data| with all the syncer data for the specified type.
- virtual syncer::SyncError GetSyncDataForType(
+ // Fills a list of SyncData. This should create an up to date representation
+ // of all the data known to the ChangeProcessor for |datatype|, and
+ // should match/be a subset of the server's view of that datatype.
+ virtual syncer::SyncDataList GetAllSyncData(syncer::ModelType type)
+ const OVERRIDE;
+
+ // Similar to above, but returns a SyncError for use by direct clients
+ // of GenericChangeProcessor that may need more error visibility.
+ virtual syncer::SyncError GetAllSyncDataReturnError(
syncer::ModelType type,
- syncer::SyncDataList* current_sync_data);
+ syncer::SyncDataList* data) const;
// Returns the number of items for this type.
virtual int GetSyncCountForType(syncer::ModelType type);
« no previous file with comments | « chrome/browser/sync/glue/favicon_cache_unittest.cc ('k') | chrome/browser/sync/glue/generic_change_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698