Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: chrome/browser/sync/glue/generic_change_processor.cc

Issue 23129007: sync: Add GetAllSyncData to sync/api (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/generic_change_processor.cc
diff --git a/chrome/browser/sync/glue/generic_change_processor.cc b/chrome/browser/sync/glue/generic_change_processor.cc
index c40fca28db7001fdc6ec56705b0805e586596e1b..8a769546f9b1e51708fc65a7af9f09d1b95ae4ee 100644
--- a/chrome/browser/sync/glue/generic_change_processor.cc
+++ b/chrome/browser/sync/glue/generic_change_processor.cc
@@ -136,9 +136,17 @@ void GenericChangeProcessor::CommitChangesFromSyncModel() {
}
}
-syncer::SyncError GenericChangeProcessor::GetSyncDataForType(
+syncer::SyncDataList GenericChangeProcessor::GetAllSyncData(
+ syncer::ModelType type) const {
+ // This is slow / memory intensive. Should be used sparingly by datatypes.
+ syncer::SyncDataList data;
+ GetAllSyncDataReturnError(type, &data);
+ return data;
+}
+
+syncer::SyncError GenericChangeProcessor::GetAllSyncDataReturnError(
syncer::ModelType type,
- syncer::SyncDataList* current_sync_data) {
+ syncer::SyncDataList* current_sync_data) const {
DCHECK(CalledOnValidThread());
std::string type_name = syncer::ModelTypeToString(type);
syncer::ReadTransaction trans(FROM_HERE, share_handle());
« no previous file with comments | « chrome/browser/sync/glue/generic_change_processor.h ('k') | chrome/browser/sync/glue/generic_change_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698