Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2312833002: Revert of Remove Platform::current checks from Mojo's error handlers in geolocation (patchset #1 id… (Closed)

Created:
4 years, 3 months ago by haraken
Modified:
4 years, 3 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert of Remove Platform::current checks from Mojo's error handlers in geolocation (patchset #1 id:1 of https://codereview.chromium.org/2271953002/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove Platform::current checks from Mojo's error handlers in geolocation > > The checks were added in https://codereview.chromium.org/2163683004/ > but are no longer needed because I already removed blink::shutdown > from the renderer's shutdown sequence. > > BUG=628999, 639244 > > Committed: https://crrev.com/8435863a81be1eee4c28131a341f8a4bce04a7b4 > Cr-Commit-Position: refs/heads/master@{#414232} TBR=sammc@chromium.org BUG=628999, 639244 NOTRY=true Review-Url: https://codereview.chromium.org/2312553003 Cr-Commit-Position: refs/heads/master@{#416480} (cherry picked from commit 556b4223eeea55a338bf38ca87b004ba23e1039a)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
haraken
4 years, 3 months ago (2016-09-06 05:14:52 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
64308ecc3480d4f9c3882b37a7f9689cb4c1bcde.

Powered by Google App Engine
This is Rietveld 408576698