Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2312553003: Revert of Remove Platform::current checks from Mojo's error handlers in geolocation (Closed)

Created:
4 years, 3 months ago by haraken
Modified:
4 years, 3 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, haraken, timvolodine, mvanouwerkerk+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove Platform::current checks from Mojo's error handlers in geolocation (patchset #1 id:1 of https://codereview.chromium.org/2271953002/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove Platform::current checks from Mojo's error handlers in geolocation > > The checks were added in https://codereview.chromium.org/2163683004/ > but are no longer needed because I already removed blink::shutdown > from the renderer's shutdown sequence. > > BUG=628999, 639244 > > Committed: https://crrev.com/8435863a81be1eee4c28131a341f8a4bce04a7b4 > Cr-Commit-Position: refs/heads/master@{#414232} TBR=sammc@chromium.org BUG=628999, 639244 NOTRY=true Committed: https://crrev.com/556b4223eeea55a338bf38ca87b004ba23e1039a Cr-Commit-Position: refs/heads/master@{#416480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
haraken
Created Revert of Remove Platform::current checks from Mojo's error handlers in geolocation
4 years, 3 months ago (2016-09-05 00:28:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312553003/1
4 years, 3 months ago (2016-09-05 00:28:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 00:32:37 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 00:35:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/556b4223eeea55a338bf38ca87b004ba23e1039a
Cr-Commit-Position: refs/heads/master@{#416480}

Powered by Google App Engine
This is Rietveld 408576698