Password manager: introduce logging for the internals page

chrome/browser/ui/login/login_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/login/login_prompt.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/lock.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/prerender/prerender_contents.h"
 #include "chrome/browser/tab_contents/tab_util.h"
+#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/resource_dispatcher_host.h"
 #include "content/public/browser/resource_request_info.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/generated_resources.h"
 #include "net/base/auth.h"
 #include "net/base/net_util.h"
 #include "net/http/http_transaction_factory.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/text_elider.h"
 
 using autofill::PasswordForm;
+using autofill::SavePasswordProgressLogger;
 using content::BrowserThread;
 using content::NavigationController;
 using content::RenderViewHost;
 using content::RenderViewHostDelegate;
 using content::ResourceDispatcherHost;
 using content::ResourceRequestInfo;
 using content::WebContents;
 
 class LoginHandlerImpl;
 
@@ skipping 83 matching lines @@
 
   content::RenderFrameHost* rfh = content::RenderFrameHost::FromID(
       render_process_host_id_, render_frame_id_);
   return WebContents::FromRenderFrameHost(rfh);
 }
 
 void LoginHandler::SetAuth(const base::string16& username,
                            const base::string16& password) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
-  if (TestAndSetAuthHandled())
+  bool already_handled = TestAndSetAuthHandled();
+  scoped_ptr<password_manager::BrowserSavePasswordProgressLogger> logger;
+  if (password_manager_ && password_manager_->client()->IsLoggingActive()) {
+    logger.reset(new password_manager::BrowserSavePasswordProgressLogger(
+        password_manager_->client()));
+    logger->LogMessage(SavePasswordProgressLogger::STRING_SET_AUTH_METHOD);

[Ilya Sherman, 2014/04/23 05:19:56]

nit: Please move the construction of the logger, as well as this first message,
to be above where |already_handled| is defined.  That helps make this logic
easier to follow.

[vabr (Chromium), 2014/04/23 18:15:35]

Done.

+    logger->LogBoolean(
+        SavePasswordProgressLogger::STRING_AUTHENTICATION_HANDLED,
+        already_handled);
+  }
+  if (already_handled )

[Ilya Sherman, 2014/04/23 05:19:56]

nit: Spurious space.

[vabr (Chromium), 2014/04/23 18:15:35]

Done.

     return;
 
   // Tell the password manager the credentials were submitted / accepted.
   if (password_manager_) {
     password_form_.username_value = username;
     password_form_.password_value = password;
     password_manager_->ProvisionallySavePassword(password_form_);
+    if (logger)

[Ilya Sherman, 2014/04/23 05:19:56]

nit: Needs curly braces.

[vabr (Chromium), 2014/04/23 18:15:35]

Done.

+      logger->LogPasswordForm(
+          SavePasswordProgressLogger::STRING_LOGINHANDLER_FORM, password_form_);
   }
 
   // Calling NotifyAuthSupplied() directly instead of posting a task
   // allows other LoginHandler instances to queue their
   // CloseContentsDeferred() before ours.  Closing dialogs in the
   // opposite order as they were created avoids races where remaining
   // dialogs in the same tab may be briefly displayed to the user
   // before they are removed.
   NotifyAuthSupplied(username, password);
 
@@ skipping 314 matching lines @@
 
 LoginHandler* CreateLoginPrompt(net::AuthChallengeInfo* auth_info,
                                 net::URLRequest* request) {
   LoginHandler* handler = LoginHandler::Create(auth_info, request);
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&LoginDialogCallback, request->url(),
                  make_scoped_refptr(auth_info), make_scoped_refptr(handler)));
   return handler;
 }