Unprefix -webkit-clip-path

Unprefix -webkit-clip-path

This CL renames '-webkit-clip-path' to 'clip-path', and makes the former
an alias of the latter.
For LayoutSVGRoot, clip-path is now applied only by the PaintLayer and
not by SVGPaintContext.

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9e619beca68cf73772ae4c9f35a21f9bb13d7e65
Cr-Commit-Position: refs/heads/master@{#418827}

[fs, 2016-09-05 12:32:30]

Description was changed from

==========
Unprefix -webkit-clip-path

BUG=633028
==========

to

==========
Unprefix -webkit-clip-path

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-05 12:32:35]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 12:32:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 12:54:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 12:54:18]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[fs, 2016-09-08 15:38:08]

Description was changed from

==========
Unprefix -webkit-clip-path

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Unprefix -webkit-clip-path

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo/discus...

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-08 15:38:58]

Description was changed from

==========
Unprefix -webkit-clip-path

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo/discus...

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Unprefix -webkit-clip-path

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-08 15:44:21]

Description was changed from

==========
Unprefix -webkit-clip-path

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Unprefix -webkit-clip-path

This CL renames '-webkit-clip-path' to 'clip-path', and makes the former an
alias of the latter. The SVGComputedStyle storage is removed in favor of the
ComputedStyle version. Support for nesting a <clipPath> with a <basic-shape>
is added. For LayoutSVGRoot, clip-path is now applied only by the PaintLayer
and not by SVGPaintContext.

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-08 19:03:15]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 19:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 20:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 20:34:34]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[fs, 2016-09-08 20:52:09]

fs@opera.com changed reviewers:
+ alancutter@chromium.org, chrishtr@chromium.org, pdr@chromium.org

[fs, 2016-09-08 20:52:10]

(Haven't looked too deeply into the SPv2 failures yet, will do that tomorrow if
needed.)

[alancutter (OOO until 2018), 2016-09-09 01:07:36]

core/animation and core/css lgtm.

[chrishtr, 2016-09-09 02:04:47]

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp (right):

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp:376: if
(clipPathOperation->type() == ClipPathOperation::SHAPE) {
Why this new code to support SHAPE? Is this to implement
the additional feature mentioned in the CL description?
if so, why add a new feature while unprefixing?

[fs, 2016-09-09 08:28:10]

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp (right):

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp:376: if
(clipPathOperation->type() == ClipPathOperation::SHAPE) {
On 2016/09/09 at 02:04:46, chrishtr wrote:
> Why this new code to support SHAPE? Is this to implement
> the additional feature mentioned in the CL description?
> if so, why add a new feature while unprefixing?

No, this is actually what falls out by starting to use ClipPathOperation
(ComputedStyle::clipPath). This was broken before because we didn't consider
'-webkit-clip-path' here although we painted it. Considering it's literally only
four additional lines (and two would be needed to avoid supporting it) it felt a
bit silly to leave it out. In contrast, the painting side of things (this is
hit-testing code) are nicely shareable, so just constitutes plugging in
ClipPathClipper, for a net reduction in code. No such luck for hit-testing
though...

[fs, 2016-09-09 08:31:35]

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp (right):

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp:376: if
(clipPathOperation->type() == ClipPathOperation::SHAPE) {
On 2016/09/09 at 08:28:10, fs wrote:
> On 2016/09/09 at 02:04:46, chrishtr wrote:
> > Why this new code to support SHAPE? Is this to implement
> > the additional feature mentioned in the CL description?
> > if so, why add a new feature while unprefixing?
> 
> No, this is actually what falls out by starting to use ClipPathOperation
(ComputedStyle::clipPath). This was broken before because we didn't consider
'-webkit-clip-path' here although we painted it. Considering it's literally only
four additional lines (and two would be needed to avoid supporting it) it felt a
bit silly to leave it out. In contrast, the painting side of things (this is
hit-testing code) are nicely shareable, so just constitutes plugging in
ClipPathClipper, for a net reduction in code. No such luck for hit-testing
though...

I should probably mention that "Support for nesting a <clipPath> with a
<basic-shape>..." as mentioned in the description is also one of those things
that are trivially supported by sharing code - although technically landing that
separately essentially mean that paint and hit-test code-paths have to diverge
in some way. (Or be very ugly/require additional code.)

[fs, 2016-09-09 16:26:42]

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp (right):

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp:376: if
(clipPathOperation->type() == ClipPathOperation::SHAPE) {
On 2016/09/09 at 08:31:35, fs wrote:
> On 2016/09/09 at 08:28:10, fs wrote:
> > On 2016/09/09 at 02:04:46, chrishtr wrote:
> > > Why this new code to support SHAPE? Is this to implement
> > > the additional feature mentioned in the CL description?
> > > if so, why add a new feature while unprefixing?
> > 
> > No, this is actually what falls out by starting to use ClipPathOperation
(ComputedStyle::clipPath). This was broken before because we didn't consider
'-webkit-clip-path' here although we painted it. Considering it's literally only
four additional lines (and two would be needed to avoid supporting it) it felt a
bit silly to leave it out. In contrast, the painting side of things (this is
hit-testing code) are nicely shareable, so just constitutes plugging in
ClipPathClipper, for a net reduction in code. No such luck for hit-testing
though...
> 
> I should probably mention that "Support for nesting a <clipPath> with a
<basic-shape>..." as mentioned in the description is also one of those things
that are trivially supported by sharing code - although technically landing that
separately essentially mean that paint and hit-test code-paths have to diverge
in some way. (Or be very ugly/require additional code.)

I've split out <basic-shape> support for 'clip-path' to
https://codereview.chromium.org/2322343003 - I'll update this CL to be based on
that as soon as I've shuttled home.

[fs, 2016-09-09 19:31:18]

Description was changed from

==========
Unprefix -webkit-clip-path

This CL renames '-webkit-clip-path' to 'clip-path', and makes the former an
alias of the latter. The SVGComputedStyle storage is removed in favor of the
ComputedStyle version. Support for nesting a <clipPath> with a <basic-shape>
is added. For LayoutSVGRoot, clip-path is now applied only by the PaintLayer
and not by SVGPaintContext.

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Unprefix -webkit-clip-path

This CL renames '-webkit-clip-path' to 'clip-path', and makes the former
an alias of the latter.
For LayoutSVGRoot, clip-path is now applied only by the PaintLayer and
not by SVGPaintContext.

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-09 20:09:41]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 20:10:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-09 20:12:16]

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp (right):

https://codereview.chromium.org/2312713002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp:376: if
(clipPathOperation->type() == ClipPathOperation::SHAPE) {
On 2016/09/09 at 16:26:42, fs wrote:
> On 2016/09/09 at 08:31:35, fs wrote:
> > On 2016/09/09 at 08:28:10, fs wrote:
> > > On 2016/09/09 at 02:04:46, chrishtr wrote:
> > > > Why this new code to support SHAPE? Is this to implement
> > > > the additional feature mentioned in the CL description?
> > > > if so, why add a new feature while unprefixing?
> > > 
> > > No, this is actually what falls out by starting to use ClipPathOperation
(ComputedStyle::clipPath). This was broken before because we didn't consider
'-webkit-clip-path' here although we painted it. Considering it's literally only
four additional lines (and two would be needed to avoid supporting it) it felt a
bit silly to leave it out. In contrast, the painting side of things (this is
hit-testing code) are nicely shareable, so just constitutes plugging in
ClipPathClipper, for a net reduction in code. No such luck for hit-testing
though...
> > 
> > I should probably mention that "Support for nesting a <clipPath> with a
<basic-shape>..." as mentioned in the description is also one of those things
that are trivially supported by sharing code - although technically landing that
separately essentially mean that paint and hit-test code-paths have to diverge
in some way. (Or be very ugly/require additional code.)
> 
> I've split out <basic-shape> support for 'clip-path' to
https://codereview.chromium.org/2322343003 - I'll update this CL to be based on
that as soon as I've shuttled home.

Done.

[commit-bot: I haz the power, 2016-09-09 21:42:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 21:42:02]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[fs, 2016-09-13 22:14:42]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 22:15:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-13 22:16:55]

<basic-shape> changes (==the complicated bits) split out and landed separately.
PTAL.

[commit-bot: I haz the power, 2016-09-13 22:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 22:19:19]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fs, 2016-09-13 22:23:08]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 22:23:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 00:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:06:57]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-14 17:23:40]

On 2016/09/13 at 22:16:55, fs wrote:
> <basic-shape> changes (==the complicated bits) split out and landed
separately. PTAL.

chrishtr, pdr: ping

[chrishtr, 2016-09-14 17:25:10]

lgtm

[fs, 2016-09-15 08:42:23]

The CQ bit was checked by fs@opera.com

[fs, 2016-09-15 08:42:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2312713002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-15 08:42:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 10:24:12]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-15 10:27:29]

Description was changed from

==========
Unprefix -webkit-clip-path

This CL renames '-webkit-clip-path' to 'clip-path', and makes the former
an alias of the latter.
For LayoutSVGRoot, clip-path is now applied only by the PaintLayer and
not by SVGPaintContext.

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Unprefix -webkit-clip-path

This CL renames '-webkit-clip-path' to 'clip-path', and makes the former
an alias of the latter.
For LayoutSVGRoot, clip-path is now applied only by the PaintLayer and
not by SVGPaintContext.

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9e619beca68cf73772ae4c9f35a21f9bb13d7e65
Cr-Commit-Position: refs/heads/master@{#418827}
==========

[commit-bot: I haz the power, 2016-09-15 10:27:31]

Patchset 7 (id:??) landed as
https://crrev.com/9e619beca68cf73772ae4c9f35a21f9bb13d7e65
Cr-Commit-Position: refs/heads/master@{#418827}