Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 2312663002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in PlainTextRange::create (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, dcheng, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in PlainTextRange::create BUG=590369 Committed: https://crrev.com/8211426fca927c616b819505cc564a2de12c7715 Cr-Commit-Position: refs/heads/master@{#416572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PlainTextRange.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-05 10:08:17 UTC) #4
tkent
lgtm
4 years, 3 months ago (2016-09-05 22:55:21 UTC) #7
yosin_UTC9
lgtm
4 years, 3 months ago (2016-09-06 01:47:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312663002/1
4 years, 3 months ago (2016-09-06 01:47:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 01:50:56 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 01:52:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8211426fca927c616b819505cc564a2de12c7715
Cr-Commit-Position: refs/heads/master@{#416572}

Powered by Google App Engine
This is Rietveld 408576698