Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2312663002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in PlainTextRange::create (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1229 matching lines...) Expand 10 before | Expand all | Expand 10 after
1240 return true; 1240 return true;
1241 } 1241 }
1242 1242
1243 void WebLocalFrameImpl::extendSelectionAndDelete(int before, int after) 1243 void WebLocalFrameImpl::extendSelectionAndDelete(int before, int after)
1244 { 1244 {
1245 TRACE_EVENT0("blink", "WebLocalFrameImpl::extendSelectionAndDelete"); 1245 TRACE_EVENT0("blink", "WebLocalFrameImpl::extendSelectionAndDelete");
1246 if (WebPlugin* plugin = focusedPluginIfInputMethodSupported()) { 1246 if (WebPlugin* plugin = focusedPluginIfInputMethodSupported()) {
1247 plugin->extendSelectionAndDelete(before, after); 1247 plugin->extendSelectionAndDelete(before, after);
1248 return; 1248 return;
1249 } 1249 }
1250
1251 // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
1252 // needs to be audited. See http://crbug.com/590369 for more details.
1253 frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
1254
1250 frame()->inputMethodController().extendSelectionAndDelete(before, after); 1255 frame()->inputMethodController().extendSelectionAndDelete(before, after);
1251 } 1256 }
1252 1257
1253 void WebLocalFrameImpl::setCaretVisible(bool visible) 1258 void WebLocalFrameImpl::setCaretVisible(bool visible)
1254 { 1259 {
1255 frame()->selection().setCaretVisible(visible); 1260 frame()->selection().setCaretVisible(visible);
1256 } 1261 }
1257 1262
1258 VisiblePosition WebLocalFrameImpl::visiblePositionForViewportPoint(const WebPoin t& pointInViewport) 1263 VisiblePosition WebLocalFrameImpl::visiblePositionForViewportPoint(const WebPoin t& pointInViewport)
1259 { 1264 {
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
2217 feature = UseCounter::ChromeLoadTimesNpnNegotiatedProtocol; 2222 feature = UseCounter::ChromeLoadTimesNpnNegotiatedProtocol;
2218 } else if (metric == "wasAlternateProtocolAvailable") { 2223 } else if (metric == "wasAlternateProtocolAvailable") {
2219 feature = UseCounter::ChromeLoadTimesWasAlternateProtocolAvailable; 2224 feature = UseCounter::ChromeLoadTimesWasAlternateProtocolAvailable;
2220 } else if (metric == "connectionInfo") { 2225 } else if (metric == "connectionInfo") {
2221 feature = UseCounter::ChromeLoadTimesConnectionInfo; 2226 feature = UseCounter::ChromeLoadTimesConnectionInfo;
2222 } 2227 }
2223 UseCounter::count(frame(), feature); 2228 UseCounter::count(frame(), feature);
2224 } 2229 }
2225 2230
2226 } // namespace blink 2231 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698