For debugging, split worker ref count into service worker and shared worker counts

For debugging, split worker ref count into service worker and shared worker counts

This should help narrow down the cause of the nonzero ref count on shutdown.

Also, move the ref counts members near the top of RenderProcessHostImpl, since
the minidumps we are seeing don't have them in memory, while earlier parts of
the object are there.

BUG=636377, 639193
Committed: https://crrev.com/26c0d0b4d4a8a5c48d9311c4e65485bae762bfff
Cr-Commit-Position: refs/heads/master@{#416545}

[falken, 2016-09-05 07:14:54]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[falken, 2016-09-05 07:14:58]

falken@chromium.org changed reviewers:
+ horo@chromium.org

[falken, 2016-09-05 07:14:59]

ptal

[commit-bot: I haz the power, 2016-09-05 07:15:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-09-05 07:47:49]

lgtm

[falken, 2016-09-05 07:59:20]

Thanks. FYI I changed the patch slightly to use different CHECKs in case the
minidump still doesn't capture the worker ref counts in memory.

[falken, 2016-09-05 07:59:42]

falken@chromium.org changed reviewers:
+ jochen@chromium.org

[falken, 2016-09-05 07:59:42]

jochen: can you review all please?

[falken, 2016-09-05 08:01:18]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 08:01:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 09:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 09:37:50]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-05 09:45:15]

lgtm with nit

https://codereview.chromium.org/2312633002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.h (right):

https://codereview.chromium.org/2312633002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.h:426: int
service_worker_ref_count_;
what about making them size_t while touching this?

[falken, 2016-09-05 12:06:45]

Thank you

https://codereview.chromium.org/2312633002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.h (right):

https://codereview.chromium.org/2312633002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.h:426: int
service_worker_ref_count_;
On 2016/09/05 09:45:15, jochen wrote:
> what about making them size_t while touching this?

Done.

[falken, 2016-09-05 12:07:12]

The CQ bit was checked by falken@chromium.org

[falken, 2016-09-05 12:07:12]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2312633002/#ps40001
(title: "size_t")

[commit-bot: I haz the power, 2016-09-05 12:07:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 14:40:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-05 14:42:26]

Description was changed from

==========
For debugging, split worker ref count into service worker and shared worker
counts

This should help narrow down the cause of the nonzero ref count on shutdown.

Also, move the ref counts members near the top of RenderProcessHostImpl, since
the minidumps we are seeing don't have them in memory, while earlier parts of
the object are there.

BUG=636377,639193
==========

to

==========
For debugging, split worker ref count into service worker and shared worker
counts

This should help narrow down the cause of the nonzero ref count on shutdown.

Also, move the ref counts members near the top of RenderProcessHostImpl, since
the minidumps we are seeing don't have them in memory, while earlier parts of
the object are there.

BUG=636377,639193

Committed: https://crrev.com/26c0d0b4d4a8a5c48d9311c4e65485bae762bfff
Cr-Commit-Position: refs/heads/master@{#416545}
==========

[commit-bot: I haz the power, 2016-09-05 14:42:28]

Patchset 3 (id:??) landed as
https://crrev.com/26c0d0b4d4a8a5c48d9311c4e65485bae762bfff
Cr-Commit-Position: refs/heads/master@{#416545}