Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: content/browser/service_worker/service_worker_process_manager.cc

Issue 2312633002: For debugging, split worker ref count into service worker and shared worker counts (Closed)
Patch Set: size_t Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_process_manager.cc
diff --git a/content/browser/service_worker/service_worker_process_manager.cc b/content/browser/service_worker/service_worker_process_manager.cc
index b6cdeb556c777b08f0af06dd85c18c2e1437777a..f3ff0482c8fea21f03f94af83e4555d9e8fd1687 100644
--- a/content/browser/service_worker/service_worker_process_manager.cc
+++ b/content/browser/service_worker/service_worker_process_manager.cc
@@ -80,7 +80,8 @@ void ServiceWorkerProcessManager::Shutdown() {
for (std::map<int, ProcessInfo>::const_iterator it = instance_info_.begin();
it != instance_info_.end();
++it) {
- RenderProcessHost::FromID(it->second.process_id)->DecrementWorkerRefCount();
+ RenderProcessHost::FromID(it->second.process_id)
+ ->DecrementServiceWorkerRefCount();
}
instance_info_.clear();
}
@@ -198,7 +199,7 @@ void ServiceWorkerProcessManager::AllocateWorkerProcess(
if (can_use_existing_process) {
int process_id = FindAvailableProcess(pattern);
if (process_id != ChildProcessHost::kInvalidUniqueID) {
- RenderProcessHost::FromID(process_id)->IncrementWorkerRefCount();
+ RenderProcessHost::FromID(process_id)->IncrementServiceWorkerRefCount();
instance_info_.insert(
std::make_pair(embedded_worker_id, ProcessInfo(process_id)));
BrowserThread::PostTask(
@@ -230,7 +231,7 @@ void ServiceWorkerProcessManager::AllocateWorkerProcess(
instance_info_.insert(
std::make_pair(embedded_worker_id, ProcessInfo(site_instance)));
- rph->IncrementWorkerRefCount();
+ rph->IncrementServiceWorkerRefCount();
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::Bind(callback, SERVICE_WORKER_OK, rph->GetID(),
true /* is_new_process */, settings));
@@ -279,7 +280,7 @@ void ServiceWorkerProcessManager::ReleaseWorkerProcess(int embedded_worker_id) {
<< "Process " << info->second.process_id
<< " was destroyed unexpectedly. Did we actually hold a reference?";
}
- rph->DecrementWorkerRefCount();
+ rph->DecrementServiceWorkerRefCount();
instance_info_.erase(info);
}
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/shared_worker/shared_worker_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698