Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 2312613002: Fix 'will execute script' condition for creating custom elements in imports (Closed)

Created:
4 years, 3 months ago by kochi
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix 'will execute script' condition for creating custom elements in imports This CL fixes the 'will execute script' flag calculation by fixing the definition lookup in HTMLConstructionSite::lookUpCustomElementDefinition(), and attributeChangedCallback() will be invoked properly for custom elements parsed and created synchronously in imports. Upgrade case is not affected by this bug. BUG=642839 Review-Url: https://codereview.chromium.org/2297853006 Cr-Commit-Position: refs/heads/master@{#416176} (cherry picked from commit 94d61015c751d3d5c6ca9deedb0637cfcbbb1283) Committed: https://chromium.googlesource.com/chromium/src/+/b3fdcae1aeaf6a1113f57cb7a35caf0cc6336c58

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
kochi
4 years, 3 months ago (2016-09-05 03:35:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b3fdcae1aeaf6a1113f57cb7a35caf0cc6336c58.

Powered by Google App Engine
This is Rietveld 408576698