Fix 'will execute script' condition for creating custom elements in imports

Fix 'will execute script' condition for creating custom elements in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case is not affected by this bug.

BUG=642839
Committed: https://crrev.com/94d61015c751d3d5c6ca9deedb0637cfcbbb1283
Cr-Commit-Position: refs/heads/master@{#416176}

[kochi, 2016-09-01 05:33:06]

Description was changed from

==========
Add a test case for crbug.com/642839

BUG=642839
==========

to

==========
Fix attributeChangedCallback for synchronous CE creation

In imports, when HTML parser creates a custom element
with attributes, attributeChangedCallback was not invoked
even when definitions's observedAttribute is given.

In HTMLConstructionSite::createHTMLElement(),
looking up the custom element definition failed for
imported document.

This fixes the lookup succeed in imports.

BUG=642839
==========

[kochi, 2016-09-01 05:33:06]

kochi@chromium.org changed reviewers:
+ dominicc@chromium.org

[kochi, 2016-09-01 05:39:49]

Description was changed from

==========
Fix attributeChangedCallback for synchronous CE creation

In imports, when HTML parser creates a custom element
with attributes, attributeChangedCallback was not invoked
even when definitions's observedAttribute is given.

In HTMLConstructionSite::createHTMLElement(),
looking up the custom element definition failed for
imported document.

This fixes the lookup succeed in imports.

BUG=642839
==========

to

==========
Fix attributeChangedCallback for synchronous CE creation

In imports, when HTML parser created a custom element
with attributes, attributeChangedCallback was not invoked
even when definitions's observedAttribute was given.

This was because in
HTMLConstructionSite::createHTMLElement(),
looking up the custom element definition failed for
imported document.

Upgrade case was not affected by this.

This CL fixes the lookup and attributeChangedCallback()
will be invoked for custom elements in imports.

BUG=642839
==========

[kochi, 2016-09-01 05:40:23]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 05:40:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kochi, 2016-09-01 05:50:09]

Description was changed from

==========
Fix attributeChangedCallback for synchronous CE creation

In imports, when HTML parser created a custom element
with attributes, attributeChangedCallback was not invoked
even when definitions's observedAttribute was given.

This was because in
HTMLConstructionSite::createHTMLElement(),
looking up the custom element definition failed for
imported document.

Upgrade case was not affected by this.

This CL fixes the lookup and attributeChangedCallback()
will be invoked for custom elements in imports.

BUG=642839
==========

to

==========
Fix willExecuteScript condition for custom elements creation in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case was not affected by this.

BUG=642839
==========

[kochi, 2016-09-01 05:50:49]

Description was changed from

==========
Fix willExecuteScript condition for custom elements creation in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case was not affected by this.

BUG=642839
==========

to

==========
Fix 'will execute script' condition for custom elements creation in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case was not affected by this.

BUG=642839
==========

[kochi, 2016-09-01 05:52:44]

Description was changed from

==========
Fix 'will execute script' condition for custom elements creation in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case was not affected by this.

BUG=642839
==========

to

==========
Fix 'will execute script' condition for creating custom elements in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case was not affected by this bug.

BUG=642839
==========

[kochi, 2016-09-01 05:53:53]

Dominic, could you take a look?

[kochi, 2016-09-01 05:54:35]

Description was changed from

==========
Fix 'will execute script' condition for creating custom elements in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case was not affected by this bug.

BUG=642839
==========

to

==========
Fix 'will execute script' condition for creating custom elements in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case is not affected by this bug.

BUG=642839
==========

[commit-bot: I haz the power, 2016-09-01 07:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 07:05:21]

Dry run: This issue passed the CQ dry run.

[dominicc (has gone to gerrit), 2016-09-02 01:01:55]

lgtm

Nice work; nice test.

LGTM modulo nits inline.

https://codereview.chromium.org/2297853006/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/custom-elements/imports/attribute-changed-callback.html
(right):

https://codereview.chromium.org/2297853006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/imports/attribute-changed-callback.html:31:
'attributeChangedCallback should have called for both upgrade and create.');
grammar: have called -> have been called (have called needs an object--have
called X)

It might be simpler to just say "be called" instead of "have been called". Below
too.

https://codereview.chromium.org/2297853006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/imports/attribute-changed-callback.html:46:
assert_array_equals(reactions, [b, d, a, b, c, d, d, c, b, a],
This list is getting long. What do you think about clearing the list after each
assert_array_equals?

[kochi, 2016-09-02 01:54:14]

The CQ bit was checked by kochi@chromium.org

[kochi, 2016-09-02 01:54:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2297853006/#ps40001
(title: "Fix for dominicc's comment")

[commit-bot: I haz the power, 2016-09-02 01:54:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kochi, 2016-09-02 02:59:15]

Thanks for the review.

https://codereview.chromium.org/2297853006/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/custom-elements/imports/attribute-changed-callback.html
(right):

https://codereview.chromium.org/2297853006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/imports/attribute-changed-callback.html:31:
'attributeChangedCallback should have called for both upgrade and create.');
On 2016/09/02 01:01:55, dominicc wrote:
> grammar: have called -> have been called (have called needs an object--have
> called X)
> 
> It might be simpler to just say "be called" instead of "have been called".
Below
> too.

Done.

https://codereview.chromium.org/2297853006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/imports/attribute-changed-callback.html:46:
assert_array_equals(reactions, [b, d, a, b, c, d, d, c, b, a],
On 2016/09/02 01:01:55, dominicc wrote:
> This list is getting long. What do you think about clearing the list after
each
> assert_array_equals?

That makes sense.
Done.

[commit-bot: I haz the power, 2016-09-02 03:12:35]

Description was changed from

==========
Fix 'will execute script' condition for creating custom elements in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case is not affected by this bug.

BUG=642839
==========

to

==========
Fix 'will execute script' condition for creating custom elements in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case is not affected by this bug.

BUG=642839
==========

[commit-bot: I haz the power, 2016-09-02 03:12:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 03:14:55]

Description was changed from

==========
Fix 'will execute script' condition for creating custom elements in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case is not affected by this bug.

BUG=642839
==========

to

==========
Fix 'will execute script' condition for creating custom elements in imports

This CL fixes the 'will execute script' flag calculation
by fixing the definition lookup in
HTMLConstructionSite::lookUpCustomElementDefinition(),
and attributeChangedCallback() will be invoked
properly for custom elements parsed and created
synchronously in imports.

Upgrade case is not affected by this bug.

BUG=642839

Committed: https://crrev.com/94d61015c751d3d5c6ca9deedb0637cfcbbb1283
Cr-Commit-Position: refs/heads/master@{#416176}
==========

[commit-bot: I haz the power, 2016-09-02 03:14:56]

Patchset 3 (id:??) landed as
https://crrev.com/94d61015c751d3d5c6ca9deedb0637cfcbbb1283
Cr-Commit-Position: refs/heads/master@{#416176}