Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 2312573002: Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (Closed)

Created:
4 years, 3 months ago by haraken
Modified:
4 years, 3 months ago
Reviewers:
yhirano
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove a Platform::current() check from Mojo's error handler in WebSocket > > The check was added in https://codereview.chromium.org/2258003003/ > but is no longer needed because I already removed blink::shutdown > from renderer's shutdown sequence. > > BUG=637949, 639244 > > Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c > Cr-Commit-Position: refs/heads/master@{#415196} TBR=yhirano@chromium.org BUG=637949, 639244 Committed: https://crrev.com/43cf914949a06e8fe3292ca60c5bf046e8a87cc9 Cr-Commit-Position: refs/heads/master@{#416487}

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
haraken
Created Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket
4 years, 3 months ago (2016-09-05 00:29:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312573002/1
4 years, 3 months ago (2016-09-05 00:29:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/252870)
4 years, 3 months ago (2016-09-05 00:39:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312573002/40001
4 years, 3 months ago (2016-09-05 00:50:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/263032)
4 years, 3 months ago (2016-09-05 01:05:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312573002/60001
4 years, 3 months ago (2016-09-05 01:08:15 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-05 02:25:57 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 02:27:54 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/43cf914949a06e8fe3292ca60c5bf046e8a87cc9
Cr-Commit-Position: refs/heads/master@{#416487}

Powered by Google App Engine
This is Rietveld 408576698