|
|
Created:
4 years, 3 months ago by haraken Modified:
4 years, 3 months ago Reviewers:
yhirano CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ )
Reason for revert:
I'll revert r413430 and its dependent CLs because r413430 caused issue 642072.
The problem is that we cannot simply remove blink::shutdown because the following scenario can happen:
1) blink::shutdown is not called. Workers are still running.
2) RenderThreadImpl gets destructed. MessageLoop gets destructed.
3) The workers may access the RenderThreadImpl and MessageLoop.
To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown().
Original issue's description:
> Remove a Platform::current() check from Mojo's error handler in WebSocket
>
> The check was added in https://codereview.chromium.org/2258003003/
> but is no longer needed because I already removed blink::shutdown
> from renderer's shutdown sequence.
>
> BUG=637949, 639244
>
> Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c
> Cr-Commit-Position: refs/heads/master@{#415196}
TBR=yhirano@chromium.org
BUG=637949, 639244
Committed: https://crrev.com/43cf914949a06e8fe3292ca60c5bf046e8a87cc9
Cr-Commit-Position: refs/heads/master@{#416487}
Patch Set 1 #Patch Set 2 : temp #Patch Set 3 : temp #Messages
Total messages: 17 (9 generated)
Created Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket
Description was changed from ========== Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove a Platform::current() check from Mojo's error handler in WebSocket > > The check was added in https://codereview.chromium.org/2258003003/ > but is no longer needed because I already removed blink::shutdown > from renderer's shutdown sequence. > > BUG=637949,639244 > > Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c > Cr-Commit-Position: refs/heads/master@{#415196} TBR=yhirano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=637949,639244 ========== to ========== Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove a Platform::current() check from Mojo's error handler in WebSocket > > The check was added in https://codereview.chromium.org/2258003003/ > but is no longer needed because I already removed blink::shutdown > from renderer's shutdown sequence. > > BUG=637949,639244 > > Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c > Cr-Commit-Position: refs/heads/master@{#415196} TBR=yhirano@chromium.org BUG=637949,639244 NOTRY=true ==========
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove a Platform::current() check from Mojo's error handler in WebSocket > > The check was added in https://codereview.chromium.org/2258003003/ > but is no longer needed because I already removed blink::shutdown > from renderer's shutdown sequence. > > BUG=637949,639244 > > Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c > Cr-Commit-Position: refs/heads/master@{#415196} TBR=yhirano@chromium.org BUG=637949,639244 NOTRY=true ========== to ========== Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove a Platform::current() check from Mojo's error handler in WebSocket > > The check was added in https://codereview.chromium.org/2258003003/ > but is no longer needed because I already removed blink::shutdown > from renderer's shutdown sequence. > > BUG=637949,639244 > > Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c > Cr-Commit-Position: refs/heads/master@{#415196} TBR=yhirano@chromium.org BUG=637949,639244 ==========
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove a Platform::current() check from Mojo's error handler in WebSocket > > The check was added in https://codereview.chromium.org/2258003003/ > but is no longer needed because I already removed blink::shutdown > from renderer's shutdown sequence. > > BUG=637949,639244 > > Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c > Cr-Commit-Position: refs/heads/master@{#415196} TBR=yhirano@chromium.org BUG=637949,639244 ========== to ========== Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove a Platform::current() check from Mojo's error handler in WebSocket > > The check was added in https://codereview.chromium.org/2258003003/ > but is no longer needed because I already removed blink::shutdown > from renderer's shutdown sequence. > > BUG=637949,639244 > > Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c > Cr-Commit-Position: refs/heads/master@{#415196} TBR=yhirano@chromium.org BUG=637949,639244 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove a Platform::current() check from Mojo's error handler in WebSocket > > The check was added in https://codereview.chromium.org/2258003003/ > but is no longer needed because I already removed blink::shutdown > from renderer's shutdown sequence. > > BUG=637949,639244 > > Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c > Cr-Commit-Position: refs/heads/master@{#415196} TBR=yhirano@chromium.org BUG=637949,639244 ========== to ========== Revert of Remove a Platform::current() check from Mojo's error handler in WebSocket (patchset #1 id:1 of https://codereview.chromium.org/2276433003/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove a Platform::current() check from Mojo's error handler in WebSocket > > The check was added in https://codereview.chromium.org/2258003003/ > but is no longer needed because I already removed blink::shutdown > from renderer's shutdown sequence. > > BUG=637949,639244 > > Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c > Cr-Commit-Position: refs/heads/master@{#415196} TBR=yhirano@chromium.org BUG=637949,639244 Committed: https://crrev.com/43cf914949a06e8fe3292ca60c5bf046e8a87cc9 Cr-Commit-Position: refs/heads/master@{#416487} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/43cf914949a06e8fe3292ca60c5bf046e8a87cc9 Cr-Commit-Position: refs/heads/master@{#416487} |