Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2312383002: Make CaretBase a DisplayItemClient. (Closed)

Created:
4 years, 3 months ago by wkorman
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Make CaretBase a DisplayItemClient. From chrishtr@'s http://crrev.com/2296203002 with test added. Fixes caret invalidation in textarea where caret is scrolled outside of visible textarea rect. BUG=634094 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2293293003 Cr-Commit-Position: refs/heads/master@{#416191} (cherry picked from commit 5153d9b53989b32068b7759aa0253a1e5662492a) Committed: https://chromium.googlesource.com/chromium/src/+/6bedbc4f9a7d362447b2dc30544479aa1484f5e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -41 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/relayout-shifts-inner-editor.html View 2 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret.html View 1 chunk +11 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret-expected.txt View 1 chunk +79 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.h View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 5 chunks +13 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wkorman
4 years, 3 months ago (2016-09-06 21:12:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bedbc4f9a7d362447b2dc30544479aa1484f5e1.

Powered by Google App Engine
This is Rietveld 408576698