|
|
Chromium Code Reviews
DescriptionUpdate WebGL 2 conformance expectations
BUG=644057, 593024
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/ea43c322211a60280a17f5d0a4874ac0c49573e7
Cr-Commit-Position: refs/heads/master@{#416858}
Patch Set 1 #Patch Set 2 : rebase only #
Total comments: 1
Messages
Total messages: 15 (7 generated)
Description was changed from ========== Update WebGL 2 conformance expectations BUG=644057, 593024 ========== to ========== Update WebGL 2 conformance expectations BUG=644057, 593024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
qiankun.miao@intel.com changed reviewers: + jmadill@chromium.org, kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org
Update test expectations. Uniform block issues on Intel Windows have been fixed. A lot of tests can pass now. Thanks jiajia and Jamie.
Nice! Not sure if the uniform buffers stuff will work - my fix apparently didn't work 100% for Windows 7 and I am not sure it's soluble. the others look good. Note the CQ won't catch this.
Description was changed from ========== Update WebGL 2 conformance expectations BUG=644057, 593024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update WebGL 2 conformance expectations BUG=644057, 593024 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
On 2016/09/07 02:58:45, Jamie Madill wrote: > Nice! Not sure if the uniform buffers stuff will work - my fix apparently didn't > work 100% for Windows 7 and I am not sure it's soluble. the others look good. > Note the CQ won't catch this. They passed locally. If the gpu waterfall fails, please add the failure back.
On 2016/09/07 03:00:37, qiankun wrote: > On 2016/09/07 02:58:45, Jamie Madill wrote: > > Nice! Not sure if the uniform buffers stuff will work - my fix apparently > didn't > > work 100% for Windows 7 and I am not sure it's soluble. the others look good. > > Note the CQ won't catch this. > > They passed locally. If the gpu waterfall fails, please add the failure back. lgtm
The CQ bit was checked by qiankun.miao@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2312373003/#ps20001 (title: "rebase only")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update WebGL 2 conformance expectations BUG=644057, 593024 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update WebGL 2 conformance expectations BUG=644057, 593024 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update WebGL 2 conformance expectations BUG=644057, 593024 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Update WebGL 2 conformance expectations BUG=644057, 593024 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ea43c322211a60280a17f5d0a4874ac0c49573e7 Cr-Commit-Position: refs/heads/master@{#416858} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ea43c322211a60280a17f5d0a4874ac0c49573e7 Cr-Commit-Position: refs/heads/master@{#416858}
Message was sent while issue was closed.
https://codereview.chromium.org/2312373003/diff/20001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (left): https://codereview.chromium.org/2312373003/diff/20001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:141: self.Fail('deqp/functional/gles3/uniformbuffers/*.html', it looks as though there are still some ubo issues: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28Ne... WebglConformance_conformance2_buffers_uniform_buffers WebglConformance_deqp_functional_gles3_uniformbuffers_multi_basic_types WebglConformance_deqp_functional_gles3_uniformbuffers_multi_nested_struct WebglConformance_deqp_functional_gles3_uniformbuffers_random WebglConformance_deqp_functional_gles3_uniformbuffers_single_nested_struct WebglConformance_deqp_functional_gles3_uniformbuffers_single_nested_struct_array WebglConformance_deqp_functional_gles3_uniformbuffers_single_struct WebglConformance_deqp_functional_gles3_uniformbuffers_single_struct_array |
