Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2312373003: Update WebGL 2 conformance expectations (Closed)

Created:
4 years, 3 months ago by qiankun
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, jiajia.qin, Yang Gu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebGL 2 conformance expectations BUG=644057, 593024 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ea43c322211a60280a17f5d0a4874ac0c49573e7 Cr-Commit-Position: refs/heads/master@{#416858}

Patch Set 1 #

Patch Set 2 : rebase only #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 3 chunks +0 lines, -9 lines 1 comment Download

Messages

Total messages: 15 (7 generated)
qiankun
Update test expectations. Uniform block issues on Intel Windows have been fixed. A lot of ...
4 years, 3 months ago (2016-09-07 02:55:22 UTC) #3
Jamie Madill
Nice! Not sure if the uniform buffers stuff will work - my fix apparently didn't ...
4 years, 3 months ago (2016-09-07 02:58:45 UTC) #4
qiankun
On 2016/09/07 02:58:45, Jamie Madill wrote: > Nice! Not sure if the uniform buffers stuff ...
4 years, 3 months ago (2016-09-07 03:00:37 UTC) #6
Zhenyao Mo
On 2016/09/07 03:00:37, qiankun wrote: > On 2016/09/07 02:58:45, Jamie Madill wrote: > > Nice! ...
4 years, 3 months ago (2016-09-07 03:30:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312373003/20001
4 years, 3 months ago (2016-09-07 05:58:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 06:08:16 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ea43c322211a60280a17f5d0a4874ac0c49573e7 Cr-Commit-Position: refs/heads/master@{#416858}
4 years, 3 months ago (2016-09-07 06:11:22 UTC) #14
Jamie Madill
4 years, 3 months ago (2016-09-07 14:52:42 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2312373003/diff/20001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (left):

https://codereview.chromium.org/2312373003/diff/20001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:141:
self.Fail('deqp/functional/gles3/uniformbuffers/*.html',
it looks as though there are still some ubo issues:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28Ne...

WebglConformance_conformance2_buffers_uniform_buffers
WebglConformance_deqp_functional_gles3_uniformbuffers_multi_basic_types
WebglConformance_deqp_functional_gles3_uniformbuffers_multi_nested_struct
WebglConformance_deqp_functional_gles3_uniformbuffers_random
WebglConformance_deqp_functional_gles3_uniformbuffers_single_nested_struct
WebglConformance_deqp_functional_gles3_uniformbuffers_single_nested_struct_array
WebglConformance_deqp_functional_gles3_uniformbuffers_single_struct
WebglConformance_deqp_functional_gles3_uniformbuffers_single_struct_array

Powered by Google App Engine
This is Rietveld 408576698