Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMetaElement.h

Issue 2312303002: Improve warnings for non-standard meta tag separators (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMetaElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLMetaElement.h b/third_party/WebKit/Source/core/html/HTMLMetaElement.h
index b82ae3b04afa0b0215e0eb6ad23f88745cf2e892..60f9db9579a0857bf44245443b4ea01e7f87176d 100644
--- a/third_party/WebKit/Source/core/html/HTMLMetaElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLMetaElement.h
@@ -56,19 +56,19 @@ public:
private:
explicit HTMLMetaElement(Document&);
- static void processViewportKeyValuePair(Document*, const String& key, const String& value, bool viewportMetaZeroValuesQuirk, void* data);
+ static void processViewportKeyValuePair(Document*, bool reportWarnings, const String& key, const String& value, bool viewportMetaZeroValuesQuirk, void* data);
static void parseContentAttribute(const String& content, void* data, Document*, bool viewportMetaZeroValuesQuirk);
void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;
InsertionNotificationRequest insertedInto(ContainerNode*) override;
void didNotifySubtreeInsertionsToDocument() override;
- static float parsePositiveNumber(Document*, const String& key, const String& value, bool* ok = 0);
+ static float parsePositiveNumber(Document*, bool reportWarnings, const String& key, const String& value, bool* ok = 0);
- static Length parseViewportValueAsLength(Document*, const String& key, const String& value);
- static float parseViewportValueAsZoom(Document*, const String& key, const String& value, bool& computedValueMatchesParsedValue, bool viewportMetaZeroValuesQuirk);
- static bool parseViewportValueAsUserZoom(Document*, const String& key, const String& value, bool& computedValueMatchesParsedValue);
- static float parseViewportValueAsDPI(Document*, const String& key, const String& value);
+ static Length parseViewportValueAsLength(Document*, bool reportWarnings, const String& key, const String& value);
+ static float parseViewportValueAsZoom(Document*, bool reportWarnings, const String& key, const String& value, bool& computedValueMatchesParsedValue, bool viewportMetaZeroValuesQuirk);
+ static bool parseViewportValueAsUserZoom(Document*, bool reportWarnings, const String& key, const String& value, bool& computedValueMatchesParsedValue);
+ static float parseViewportValueAsDPI(Document*, bool reportWarnings, const String& key, const String& value);
static void reportViewportWarning(Document*, ViewportErrorCode, const String& replacement1, const String& replacement2);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698