Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLMetaElement.h

Issue 2312303002: Improve warnings for non-standard meta tag separators (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // attributes. 49 // attributes.
50 WTF::TextEncoding computeEncoding() const; 50 WTF::TextEncoding computeEncoding() const;
51 51
52 const AtomicString& content() const; 52 const AtomicString& content() const;
53 const AtomicString& httpEquiv() const; 53 const AtomicString& httpEquiv() const;
54 const AtomicString& name() const; 54 const AtomicString& name() const;
55 55
56 private: 56 private:
57 explicit HTMLMetaElement(Document&); 57 explicit HTMLMetaElement(Document&);
58 58
59 static void processViewportKeyValuePair(Document*, const String& key, const String& value, bool viewportMetaZeroValuesQuirk, void* data); 59 static void processViewportKeyValuePair(Document*, bool reportWarnings, cons t String& key, const String& value, bool viewportMetaZeroValuesQuirk, void* data );
60 static void parseContentAttribute(const String& content, void* data, Documen t*, bool viewportMetaZeroValuesQuirk); 60 static void parseContentAttribute(const String& content, void* data, Documen t*, bool viewportMetaZeroValuesQuirk);
61 61
62 void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicS tring&) override; 62 void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicS tring&) override;
63 InsertionNotificationRequest insertedInto(ContainerNode*) override; 63 InsertionNotificationRequest insertedInto(ContainerNode*) override;
64 void didNotifySubtreeInsertionsToDocument() override; 64 void didNotifySubtreeInsertionsToDocument() override;
65 65
66 static float parsePositiveNumber(Document*, const String& key, const String& value, bool* ok = 0); 66 static float parsePositiveNumber(Document*, bool reportWarnings, const Strin g& key, const String& value, bool* ok = 0);
67 67
68 static Length parseViewportValueAsLength(Document*, const String& key, const String& value); 68 static Length parseViewportValueAsLength(Document*, bool reportWarnings, con st String& key, const String& value);
69 static float parseViewportValueAsZoom(Document*, const String& key, const St ring& value, bool& computedValueMatchesParsedValue, bool viewportMetaZeroValuesQ uirk); 69 static float parseViewportValueAsZoom(Document*, bool reportWarnings, const String& key, const String& value, bool& computedValueMatchesParsedValue, bool vi ewportMetaZeroValuesQuirk);
70 static bool parseViewportValueAsUserZoom(Document*, const String& key, const String& value, bool& computedValueMatchesParsedValue); 70 static bool parseViewportValueAsUserZoom(Document*, bool reportWarnings, con st String& key, const String& value, bool& computedValueMatchesParsedValue);
71 static float parseViewportValueAsDPI(Document*, const String& key, const Str ing& value); 71 static float parseViewportValueAsDPI(Document*, bool reportWarnings, const S tring& key, const String& value);
72 72
73 static void reportViewportWarning(Document*, ViewportErrorCode, const String & replacement1, const String& replacement2); 73 static void reportViewportWarning(Document*, ViewportErrorCode, const String & replacement1, const String& replacement2);
74 74
75 void process(); 75 void process();
76 void processViewportContentAttribute(const String& content, ViewportDescript ion::Type origin); 76 void processViewportContentAttribute(const String& content, ViewportDescript ion::Type origin);
77 }; 77 };
78 78
79 } // namespace blink 79 } // namespace blink
80 80
81 #endif // HTMLMetaElement_h 81 #endif // HTMLMetaElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698