Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2312173002: Revert of Improve usage of window rectangles (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
CC:
reviews_skia.org, nv_mark, dogben_google.com
Base URL:
https://skia.googlesource.com/skia.git@upload_drawsinreducedclip
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Improve usage of window rectangles (patchset #9 id:160001 of https://codereview.chromium.org/2289363005/ ) Reason for revert: broke build. See https://build.chromium.org/p/client.skia/builders/Perf-Win8-MSVC-ShuttleA-GPU-GTX960-x86_64-Debug/builds/186 Original issue's description: > Improve usage of window rectangles > > * Skips non-AA diff rect elements and replaces them with window > rectangles. > * Places window rectangles in the interiors of antialiased diff rects. > * Arranges two overlapping window rectangles in a plus shape inside of > diff rounded rects. > * Enables window rectangles when clearing and generating clip masks. > > GTX 960 perf result (with vs. without window rectangles): > > glinst4 msaa16 gpu > keymobi_pinterest.skp 0.48 -> 0.17 [ 35%] 2.77 -> 1.49 [ 54%] 0.22 -> 0.16 [ 70%] > keymobi_digg_com.skp 0.42 -> 0.23 [ 55%] 2.34 -> 1.08 [ 46%] 0.25 -> 0.21 [ 83%] > desk_jsfiddlebigcar.skp 0.28 -> 0.16 [ 59%] 1.70 -> 0.96 [ 57%] 0.19 -> 0.14 [ 70%] > top25desk_wordpress.skp 0.45 -> 0.18 [ 40%] 2.78 -> 1.53 [ 55%] 0.21 -> 0.19 [ 94%] > top25desk_weather_com.skp 2.01 -> 1.93 [ 96%] 23.5 -> 2.54 [ 11%] 1.90 -> 1.68 [ 88%] > keymobi_blogger.skp 0.57 -> 0.37 [ 65%] 2.87 -> 1.54 [ 54%] 0.43 -> 0.33 [ 77%] > keymobi_linkedin.skp 0.32 -> 0.17 [ 51%] 1.93 -> 1.04 [ 54%] 0.17 -> 0.15 [ 91%] > keymobi_bing_com_search_... 0.29 -> 0.25 [ 83%] 1.85 -> 1.23 [ 66%] 0.50 -> 0.24 [ 48%] > keymobi_theverge_com_201... 1.00 -> 0.67 [ 68%] 9.46 -> 3.84 [ 41%] 0.72 -> 0.65 [ 90%] > keymobi_sfgate_com_.skp 1.56 -> 1.13 [ 72%] 4.49 -> 2.86 [ 64%] 1.54 -> 1.11 [ 72%] > keymobi_ftw_usatoday_com... 0.59 -> 0.34 [ 57%] 2.80 -> 1.54 [ 55%] 1.21 -> 1.20 [ 99%] > keymobi_shop_mobileweb_e... 0.46 -> 0.32 [ 70%] 2.60 -> 1.26 [ 48%] 0.35 -> 0.34 [ 97%] > keymobi_cnn_com.skp 0.68 -> 0.42 [ 63%] 3.40 -> 2.10 [ 62%] 0.49 -> 0.45 [ 93%] > keymobi_plus_google_com_... 0.77 -> 0.46 [ 60%] 4.83 -> 3.56 [ 74%] 0.52 -> 0.46 [ 89%] > keymobi_wordpress.skp 0.50 -> 0.40 [ 81%] 2.60 -> 1.31 [ 50%] 0.40 -> 0.37 [ 91%] > keymobi_androidpolice_co... 0.84 -> 0.73 [ 87%] 4.15 -> 2.05 [ 49%] 0.77 -> 0.67 [ 87%] > keymobi_online_wsj_com_h... 0.55 -> 0.43 [ 78%] 2.91 -> 1.66 [ 57%] 0.45 -> 0.41 [ 90%] > keymobi_iphone_capitolvo... 1.18 -> 0.96 [ 81%] 6.26 -> 4.96 [ 79%] 0.95 -> 0.92 [ 97%] > keymobi_wikipedia__1_tab... 0.46 -> 0.41 [ 89%] 2.51 -> 1.24 [ 49%] 0.40 -> 0.38 [ 95%] > keymobi_wikipedia__1_tab... 0.46 -> 0.42 [ 90%] 2.52 -> 1.25 [ 50%] 0.40 -> 0.38 [ 96%] > keymobi_boingboing_net.skp 0.62 -> 0.56 [ 90%] 3.15 -> 1.80 [ 57%] 0.61 -> 0.56 [ 92%] > keymobi_cnn_com_2012_10_... 0.86 -> 0.82 [ 95%] 2.81 -> 1.50 [ 53%] 0.91 -> 0.83 [ 91%] > top25desk_techcrunch_com... 0.61 -> 0.56 [ 92%] 3.03 -> 1.76 [ 58%] 0.62 -> 0.56 [ 91%] > top25desk_ebay_com.skp 1.18 -> 1.08 [ 92%] 2.23 -> 1.24 [ 56%] 1.14 -> 1.09 [ 96%] > desk_css3gradients.skp 0.64 -> 0.61 [ 95%] 2.99 -> 1.54 [ 52%] 0.62 -> 0.61 [ 99%] > top25desk_blogger.skp 0.61 -> 0.59 [ 96%] 2.50 -> 1.37 [ 55%] 0.60 -> 0.57 [ 95%] > keymobi_nytimes_com_.skp 0.65 -> 0.64 [ 98%] 2.69 -> 1.42 [ 53%] 0.62 -> 0.59 [ 96%] > keymobi_wowwiki_com_worl... 0.99 -> 0.92 [ 92%] 3.46 -> 2.06 [ 60%] 0.98 -> 0.95 [ 96%] > keymobi_cuteoverload_com... 1.37 -> 1.26 [ 92%] 3.24 -> 2.45 [ 76%] 1.38 -> 1.35 [ 98%] > keymobi_mobile_news_sand... 0.88 -> 0.81 [ 93%] 3.50 -> 2.07 [ 59%] 0.82 -> 0.81 [100%] > top25desk_linkedin.skp 0.87 -> 0.87 [100%] 2.92 -> 1.73 [ 59%] 0.94 -> 0.86 [ 91%] > top25desk_docs___1_open_... 1.43 -> 1.36 [ 95%] 1.87 -> 1.42 [ 76%] 0.73 -> 0.66 [ 91%] > keymobi_reddit_com_r_pro... 0.68 -> 0.66 [ 96%] 2.49 -> 1.23 [ 49%] 0.65 -> 0.66 [102%] > ... > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289363005 > > Committed: https://skia.googlesource.com/skia/+/db42be9a326c747ff92ed1da8c3536c5b3e8e22b TBR=bsalomon@google.com,egdaniel@google.com,robertphillips@google.com,csmartdalton@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c3bfcb803abb1f45658e9eae9f75b428a4476e75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -694 lines) Patch
D gm/windowrectangles.cpp View 1 chunk +0 lines, -304 lines 0 comments Download
M gyp/gpu.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 2 chunks +27 lines, -0 lines 0 comments Download
M include/private/GrSurfaceProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrAppliedClip.h View 4 chunks +10 lines, -13 lines 0 comments Download
M src/gpu/GrClipStackClip.cpp View 3 chunks +19 lines, -13 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrFixedClip.h View 2 chunks +21 lines, -16 lines 0 comments Download
M src/gpu/GrFixedClip.cpp View 2 chunks +10 lines, -34 lines 0 comments Download
M src/gpu/GrPipeline.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrReducedClip.h View 4 chunks +11 lines, -21 lines 0 comments Download
M src/gpu/GrReducedClip.cpp View 7 chunks +9 lines, -109 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/GrRenderTargetPriv.h View 1 chunk +1 line, -1 line 0 comments Download
D src/gpu/GrScissorState.h View 1 chunk +0 lines, -40 lines 0 comments Download
M src/gpu/GrWindowRectangles.h View 4 chunks +15 lines, -6 lines 0 comments Download
D src/gpu/GrWindowRectsState.h View 1 chunk +0 lines, -60 lines 0 comments Download
M src/gpu/batches/GrClearBatch.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 3 chunks +25 lines, -23 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 5 chunks +19 lines, -22 lines 0 comments Download
M src/gpu/vk/GrVkGpuCommandBuffer.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/ProxyTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/WindowRectanglesTest.cpp View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
caryclark
Created Revert of Improve usage of window rectangles
4 years, 3 months ago (2016-09-06 13:44:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312173002/1
4 years, 3 months ago (2016-09-06 13:44:11 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 14:09:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c3bfcb803abb1f45658e9eae9f75b428a4476e75

Powered by Google App Engine
This is Rietveld 408576698