src/gpu/vk/GrVkGpuCommandBuffer.cpp - Issue 2312173002: Revert of Improve usage of window rectangles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkGpuCommandBuffer.cpp

Issue 2312173002: Revert of Improve usage of window rectangles (Closed) Base URL: https://skia.googlesource.com/skia.git@upload_drawsinreducedclip

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/vk/GrVkGpuCommandBuffer.cpp

diff --git a/src/gpu/vk/GrVkGpuCommandBuffer.cpp b/src/gpu/vk/GrVkGpuCommandBuffer.cpp

index e57c9962b092e69b7e6a533e2f19d2b826807362..d7a030d24156bafa10e4c588480210db287af8bf 100644

--- a/src/gpu/vk/GrVkGpuCommandBuffer.cpp

+++ b/src/gpu/vk/GrVkGpuCommandBuffer.cpp

@@ -170,7 +170,6 @@

const GrFixedClip& clip,

bool insideStencilMask) {

SkASSERT(target);

- SkASSERT(!clip.hasWindowRectangles());

GrVkRenderTarget* vkRT = static_cast<GrVkRenderTarget*>(target);

GrStencilAttachment* sb = target->renderTargetPriv().getStencilAttachment();

@@ -224,7 +223,6 @@

void GrVkGpuCommandBuffer::onClear(GrRenderTarget* target, const GrFixedClip& clip, GrColor color) {

// parent class should never let us get here with no RT

SkASSERT(target);

- SkASSERT(!clip.hasWindowRectangles());

VkClearColorValue vkColor;

GrColorToRGBAFloat(color, vkColor.float32);

« no previous file with comments | « src/gpu/gl/GrGLGpu.cpp ('k') | tests/ProxyTest.cpp » ('j') | no next file with comments »