Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: third_party/WebKit/Source/bindings/scripts/utilities.py

Issue 2312093003: Generated bindings for IDL callback functions (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/utilities.py
diff --git a/third_party/WebKit/Source/bindings/scripts/utilities.py b/third_party/WebKit/Source/bindings/scripts/utilities.py
index 2d812434f9be78697ee4a71d9e49fde892635fba..df3ecea7cc608e220ddf54c390b02954f5c37519 100644
--- a/third_party/WebKit/Source/bindings/scripts/utilities.py
+++ b/third_party/WebKit/Source/bindings/scripts/utilities.py
@@ -91,6 +91,10 @@ class ComponentInfoProvider(object):
def include_path_for_union_types(self, union_type):
return None
+ @property
+ def callback_functions(self):
+ return {}
+
class ComponentInfoProviderCore(ComponentInfoProvider):
def __init__(self, interfaces_info, component_info):
@@ -123,6 +127,10 @@ class ComponentInfoProviderCore(ComponentInfoProvider):
return 'bindings/core/v8/%s.h' % name
@property
+ def callback_functions(self):
+ return self._component_info['callback_functions']
+
+ @property
def specifier_for_export(self):
return 'CORE_EXPORT '
@@ -174,6 +182,11 @@ class ComponentInfoProviderModules(ComponentInfoProvider):
return 'bindings/modules/v8/%s.h' % name
@property
+ def callback_functions(self):
+ # TODO(lkawai): Currrently modules can not use callback functions defined in core.
peria 2016/09/15 01:14:32 This comment shows an issue which should be fixed.
lkawai 2016/09/16 05:05:49 Done.
+ return self._component_info_modules['callback_functions']
+
+ @property
def specifier_for_export(self):
return 'MODULES_EXPORT '

Powered by Google App Engine
This is Rietveld 408576698