Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

Issue 2312093003: Generated bindings for IDL callback functions (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py
diff --git a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py
index ab824c72ed433a555329867e5a92c0877a9a33b4..597909819676c899444e68788b7946057835c944 100755
--- a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py
+++ b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py
@@ -219,7 +219,10 @@ class InterfaceInfoCollector(object):
self.typedefs.update(definitions.typedefs)
for callback_function_name, callback_function in definitions.callback_functions.iteritems():
if 'ExperimentalCallbackFunction' in callback_function.extended_attributes:
bashi 2016/09/13 00:35:05 Please add a comment to describe what 'component_d
lkawai 2016/09/16 05:05:49 Done.
- self.callback_functions[callback_function_name] = callback_function
+ self.callback_functions[callback_function_name] = {
+ 'callback_function': callback_function,
+ 'component_dir': idl_filename_to_component(idl_filename),
+ }
# Check enum duplication.
for enum_name in definitions.enumerations.keys():
for defined_enum in self.enumerations:

Powered by Google App Engine
This is Rietveld 408576698