Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: pkg/analysis_server/tool/spec/spec_input.html

Issue 2312073003: Issue 27078. Describe RefactoringProblemSeverity values. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/tool/spec/spec_input.html
diff --git a/pkg/analysis_server/tool/spec/spec_input.html b/pkg/analysis_server/tool/spec/spec_input.html
index 0839a70da2c070f83d515662c12365691ce08a43..cadad70e326858764ba8b77aed031e847c2edbf1 100644
--- a/pkg/analysis_server/tool/spec/spec_input.html
+++ b/pkg/analysis_server/tool/spec/spec_input.html
@@ -3613,10 +3613,40 @@
returned by the refactoring requests.
</p>
<enum>
- <value><code>INFO</code></value>
- <value><code>WARNING</code></value>
- <value><code>ERROR</code></value>
- <value><code>FATAL</code></value>
+ <value>
+ <code>INFO</code>
+ <p>A minor code problem. No example, because it is not used yet.
+ </p>
+ </value>
+ <value>
+ <code>WARNING</code>
+ <p>A minor code problem. For example names of local variables
+ should be camel case and start with a lower case letter. Staring
+ the name of a variable with an upper case is OK from the language
+ point of view, but it is nice to warn the user.
+ </p>
+ </value>
+ <value>
+ <code>ERROR</code>
+ <p>The refactoring technically can be performed, but there is a
+ logical problem. For example the name of a local variable being
+ extracted conflicts with another name in the scope, or
+ duplicate parameter names in the method being extracted, or
+ a conflict between a parameter name and a local variable, etc.
+ In some cases the location of the problem is also provided, so
+ the IDE can show user the location and the problem, and let the
+ user decide whether she wants to perform the refactoring. For
+ example the name conflict might be expected, and the user wants
+ to fix it afterwards.
+ </p>
+ </value>
+ <value>
+ <code>FATAL</code>
+ <p>A fatal error, which prevents performing the refactoring.
+ For example the name of a local variable being extracted is not a
+ valid identifier, or selection is not a valid expression.
+ </p>
+ </value>
</enum>
</type>
<type name="RemoveContentOverlay">
« no previous file with comments | « pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698