Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java

Issue 2312073003: Issue 27078. Describe RefactoringProblemSeverity values. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java
diff --git a/pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java b/pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java
index 35c8296247f61b1486126e3d9d34b4b84590bd51..a8bfbdfafe37a894591e893540deee7f828c69f5 100644
--- a/pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java
+++ b/pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java
@@ -23,12 +23,33 @@ package org.dartlang.analysis.server.protocol;
*/
public class RefactoringProblemSeverity {
+ /**
+ * A minor code problem. No example, because it is not used yet.
+ */
public static final String INFO = "INFO";
+ /**
+ * A minor code problem. For example names of local variables should be camel case and start with a
+ * lower case letter. Staring the name of a variable with an upper case is OK from the language
+ * point of view, but it is nice to warn the user.
+ */
public static final String WARNING = "WARNING";
+ /**
+ * The refactoring technically can be performed, but there is a logical problem. For example the
+ * name of a local variable being extracted conflicts with another name in the scope, or duplicate
+ * parameter names in the method being extracted, or a conflict between a parameter name and a
+ * local variable, etc. In some cases the location of the problem is also provided, so the IDE can
+ * show user the location and the problem, and let the user decide whether she wants to perform the
+ * refactoring. For example the name conflict might be expected, and the user wants to fix it
+ * afterwards.
+ */
public static final String ERROR = "ERROR";
+ /**
+ * A fatal error, which prevents performing the refactoring. For example the name of a local
+ * variable being extracted is not a valid identifier, or selection is not a valid expression.
+ */
public static final String FATAL = "FATAL";
}
« no previous file with comments | « pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart ('k') | pkg/analysis_server/tool/spec/spec_input.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698