Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2312003005: [turbofan] Handle word32 truncation in word32->tagged representation change. (Closed)

Created:
4 years, 3 months ago by Jarin
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Handle word32 truncation in word32->tagged representation change. Similarly to the word32->float64 case, we interpret word32 as uint32 if the value is word32 truncated. This is fine because the users declared they only care about mod 2^32 of the value (that's what word32 truncation means). This CL also removes the ad-hoc handling of this situation (https://codereview.chromium.org/2311903002). BUG=chromium:644048 Committed: https://crrev.com/01cc19fa6f76511f3cc88e0af795620c913b8304 Cr-Commit-Position: refs/heads/master@{#39224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M src/compiler/representation-change.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/representation-change.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Jarin
Could you take a look, please?
4 years, 3 months ago (2016-09-06 20:12:27 UTC) #8
Benedikt Meurer
Awesome, thanks. LGTM.
4 years, 3 months ago (2016-09-06 20:43:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312003005/1
4 years, 3 months ago (2016-09-06 20:55:41 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 20:57:42 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:58:39 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01cc19fa6f76511f3cc88e0af795620c913b8304
Cr-Commit-Position: refs/heads/master@{#39224}

Powered by Google App Engine
This is Rietveld 408576698