Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2311903002: [turbofan] Don't propagate truncations if output is tagged. (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't propagate truncations if output is tagged. Disable the propagation of truncations through Phi, Select or TypeGuard if the output representation is tagged, because when the truncations are taken we don't necessarily reflect this in the types and therefore we might end up in a situation where we produce a word32 value, the type says Number, and now we need to change that to tagged, which is not possible since we don't know how to interpret the bits, i.e. whether the value is Signed32 or Unsigned32. BUG=chromium:644048 Committed: https://crrev.com/8af781ea8220f5fa70bef616e5779cee21064543 Cr-Commit-Position: refs/heads/master@{#39186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/compiler/simplified-lowering.cc View 3 chunks +9 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/regress-644048.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mvstanton
Hi Benedikt, Here is the straightforward fix (back-mergable). --Mike
4 years, 3 months ago (2016-09-05 13:36:49 UTC) #4
Benedikt Meurer
Thanks, LGTM. I tweaked the description a bit.
4 years, 3 months ago (2016-09-05 16:42:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311903002/1
4 years, 3 months ago (2016-09-05 20:52:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 20:54:33 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 20:55:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8af781ea8220f5fa70bef616e5779cee21064543
Cr-Commit-Position: refs/heads/master@{#39186}

Powered by Google App Engine
This is Rietveld 408576698