Chromium Code Reviews Chromium Code Reviews
Issue
2311983003:
Revert of Remove WTF::isShutdown() (patchset #1 id:1 of https://codereview.chromium.org/2277663002/… (Closed)
DescriptionRevert of Remove WTF::isShutdown() (patchset #1 id:1 of https://codereview.chromium.org/2277663002/ )
Reason for revert:
I'll revert r413430 and its dependent CLs because r413430 caused issue 642072.
The problem is that we cannot simply remove blink::shutdown because the following scenario can happen:
1) blink::shutdown is not called. Workers are still running.
2) RenderThreadImpl gets destructed. MessageLoop gets destructed.
3) The workers may access the RenderThreadImpl and MessageLoop.
To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown().
Original issue's description:
> Remove WTF::isShutdown()
>
> Now it's unused.
>
> BUG=639244
>
> Committed: https://crrev.com/47f9c2d1ca781e1e4df5dc05b74200a6ba696afe
> Cr-Commit-Position: refs/heads/master@{#414030}
TBR=yutak@chromium.org
BUG=639244
NOTRY=true
Review-Url: https://codereview.chromium.org/2311713002
Cr-Commit-Position: refs/heads/master@{#416481}
(cherry picked from commit 2302bf7e2cf6bbaa8f6b43a966acebbe974b43b9)
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|
||||||||||||||||||||||||||||
