Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2311713002: Revert of Remove WTF::isShutdown() (Closed)

Created:
4 years, 3 months ago by haraken
Modified:
4 years, 3 months ago
Reviewers:
Yuta Kitamura
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove WTF::isShutdown() (patchset #1 id:1 of https://codereview.chromium.org/2277663002/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Remove WTF::isShutdown() > > Now it's unused. > > BUG=639244 > > Committed: https://crrev.com/47f9c2d1ca781e1e4df5dc05b74200a6ba696afe > Cr-Commit-Position: refs/heads/master@{#414030} TBR=yutak@chromium.org BUG=639244 NOTRY=true Committed: https://crrev.com/2302bf7e2cf6bbaa8f6b43a966acebbe974b43b9 Cr-Commit-Position: refs/heads/master@{#416481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/wtf/WTF.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/WTF.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
haraken
Created Revert of Remove WTF::isShutdown()
4 years, 3 months ago (2016-09-05 00:30:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311713002/1
4 years, 3 months ago (2016-09-05 00:32:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 00:35:33 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 00:38:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2302bf7e2cf6bbaa8f6b43a966acebbe974b43b9
Cr-Commit-Position: refs/heads/master@{#416481}

Powered by Google App Engine
This is Rietveld 408576698