Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 231193002: Makes recreating a layer inherit target visibility and opacity (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Makes recreating a layer inherit target visibility and opacity This better matches expectations. BUG=none TEST=none R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M ui/compositor/compositor.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/layer_owner.cc View 1 chunk +2 lines, -1 line 0 comments Download
A ui/compositor/layer_owner_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M ui/wm/core/window_animations.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
6 years, 8 months ago (2014-04-09 16:23:01 UTC) #1
sky
I tried maximizing and closing a window and didn't see any weirdness. If you think ...
6 years, 8 months ago (2014-04-09 16:23:43 UTC) #2
oshima
On 2014/04/09 16:23:43, sky wrote: > I tried maximizing and closing a window and didn't ...
6 years, 8 months ago (2014-04-09 17:28:13 UTC) #3
sky
It all seems to work for me. -Scott On Wed, Apr 9, 2014 at 10:28 ...
6 years, 8 months ago (2014-04-09 18:18:33 UTC) #4
oshima
On 2014/04/09 18:18:33, sky wrote: > It all seems to work for me. > > ...
6 years, 8 months ago (2014-04-09 18:27:51 UTC) #5
oshima
On 2014/04/09 18:18:33, sky wrote: > It all seems to work for me. > > ...
6 years, 8 months ago (2014-04-09 18:27:51 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-09 19:15:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/231193002/1
6 years, 8 months ago (2014-04-09 19:16:34 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 19:48:49 UTC) #9
Message was sent while issue was closed.
Change committed as 262778

Powered by Google App Engine
This is Rietveld 408576698