Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(35)

Issue 2311923002: Don't propagate synchronous Future.wait errors immediately. (Closed)

Created:
3 years, 1 month ago by floitsch
Modified:
3 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't propagate synchronous Future.wait errors immediately. Fixes #27249. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/70c48b9a2ed6249495b69500622238b81c0bfb62

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add test. #

Total comments: 6

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M sdk/lib/async/future.dart View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M tests/lib/async/future_test.dart View 1 2 3 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
floitsch
3 years, 1 month ago (2016-09-05 13:56:17 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2311923002/diff/1/sdk/lib/async/future.dart File sdk/lib/async/future.dart (right): https://codereview.chromium.org/2311923002/diff/1/sdk/lib/async/future.dart#newcode329 sdk/lib/async/future.dart:329: return new Future.error(e, st); I would say to ...
3 years, 1 month ago (2016-09-05 14:30:12 UTC) #4
floitsch
Added a test.
3 years, 1 month ago (2016-09-06 09:48:32 UTC) #5
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2311923002/diff/20001/sdk/lib/async/future.dart File sdk/lib/async/future.dart (right): https://codereview.chromium.org/2311923002/diff/20001/sdk/lib/async/future.dart#newcode326 sdk/lib/async/future.dart:326: // Don't just complete the existing `_Future` since ...
3 years, 1 month ago (2016-09-06 09:53:27 UTC) #6
floitsch
https://codereview.chromium.org/2311923002/diff/20001/sdk/lib/async/future.dart File sdk/lib/async/future.dart (right): https://codereview.chromium.org/2311923002/diff/20001/sdk/lib/async/future.dart#newcode326 sdk/lib/async/future.dart:326: // Don't just complete the existing `_Future` since that ...
3 years, 1 month ago (2016-09-06 09:57:16 UTC) #7
floitsch
3 years, 1 month ago (2016-09-06 09:57:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
70c48b9a2ed6249495b69500622238b81c0bfb62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698