Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 23119004: Avoid -O3 in nacl as it does not play well with -W. (Closed)

Created:
7 years, 4 months ago by kmixter2
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Avoid -O3 in nacl as it does not play well with -W. Also cleans up some uninitialized data I saw while investigating the problem. R=jkummerow@chromium.org, machenbach@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M build/toolchain.gypi View 3 chunks +19 lines, -5 lines 0 comments Download
M src/effects.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
lgtm with comments: It fixes the issue. Even though, I am not happy that toolchain.gypi ...
7 years, 4 months ago (2013-08-14 15:23:59 UTC) #1
kmixter2
I agree. I am sorry for adding more exceptions.
7 years, 4 months ago (2013-08-14 22:36:54 UTC) #2
Jakob Kummerow
LGTM. Same feelings here -- toolchain.gypi is getting messy, but when it's needed to fix ...
7 years, 4 months ago (2013-08-19 12:48:37 UTC) #3
kmixter2
Thanks. I've checked the commit button - though I doubt there's a commit queue for ...
7 years, 4 months ago (2013-08-19 23:22:54 UTC) #4
Jakob Kummerow
Indeed, there's no CQ for V8. I'll land this for you.
7 years, 4 months ago (2013-08-20 08:05:35 UTC) #5
Jakob Kummerow
7 years, 4 months ago (2013-08-20 08:12:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r16235.

Powered by Google App Engine
This is Rietveld 408576698