Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: build/toolchain.gypi

Issue 23119004: Avoid -O3 in nacl as it does not play well with -W. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/effects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 the V8 project authors. All rights reserved. 1 # Copyright 2013 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 'cflags': [ 554 'cflags': [
555 '-fdata-sections', 555 '-fdata-sections',
556 '-ffunction-sections', 556 '-ffunction-sections',
557 '-O1', # TODO(2807) should be -O3. 557 '-O1', # TODO(2807) should be -O3.
558 ], 558 ],
559 }], 559 }],
560 ['v8_optimized_debug==2', { 560 ['v8_optimized_debug==2', {
561 'cflags!': [ 561 'cflags!': [
562 '-O0', 562 '-O0',
563 '-O1', 563 '-O1',
564 '-O2',
565 '-Os', 564 '-Os',
566 ], 565 ],
567 'cflags': [ 566 'cflags': [
568 '-fdata-sections', 567 '-fdata-sections',
569 '-ffunction-sections', 568 '-ffunction-sections',
570 '-O3',
571 ], 569 ],
570 'conditions': [
571 # TODO(crbug.com/272548): Avoid -O3 in NaCl
572 ['nacl_target_arch=="none"', {
573 'cflags': ['-O3'],
574 'cflags!': ['-O2'],
575 }, {
576 'cflags': ['-O2'],
577 'cflags!': ['-O3'],
578 }],
579 ]
572 }], 580 }],
573 ['v8_optimized_debug!=0 and gcc_version==44 and clang==0', { 581 ['v8_optimized_debug!=0 and gcc_version==44 and clang==0', {
574 'cflags': [ 582 'cflags': [
575 # Avoid crashes with gcc 4.4 in the v8 test suite. 583 # Avoid crashes with gcc 4.4 in the v8 test suite.
576 '-fno-tree-vrp', 584 '-fno-tree-vrp',
577 ], 585 ],
578 }], 586 }],
579 ], 587 ],
580 }], 588 }],
581 ['OS=="linux" and v8_enable_backtrace==1', { 589 ['OS=="linux" and v8_enable_backtrace==1', {
(...skipping 25 matching lines...) Expand all
607 }], 615 }],
608 ], 616 ],
609 }, 617 },
610 }], 618 }],
611 ], 619 ],
612 }, # Debug 620 }, # Debug
613 'Release': { 621 'Release': {
614 'conditions': [ 622 'conditions': [
615 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd"', { 623 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd"', {
616 'cflags!': [ 624 'cflags!': [
617 '-O2',
618 '-Os', 625 '-Os',
619 ], 626 ],
620 'cflags': [ 627 'cflags': [
621 '-fdata-sections', 628 '-fdata-sections',
622 '-ffunction-sections', 629 '-ffunction-sections',
623 '-O3',
624 '<(wno_array_bounds)', 630 '<(wno_array_bounds)',
625 ], 631 ],
626 'conditions': [ 632 'conditions': [
627 [ 'gcc_version==44 and clang==0', { 633 [ 'gcc_version==44 and clang==0', {
628 'cflags': [ 634 'cflags': [
629 # Avoid crashes with gcc 4.4 in the v8 test suite. 635 # Avoid crashes with gcc 4.4 in the v8 test suite.
630 '-fno-tree-vrp', 636 '-fno-tree-vrp',
631 ], 637 ],
632 }], 638 }],
633 ], 639 # TODO(crbug.com/272548): Avoid -O3 in NaCl
640 ['nacl_target_arch=="none"', {
641 'cflags': ['-O3'],
642 'cflags!': ['-O2'],
643 }, {
644 'cflags': ['-O2'],
645 'cflags!': ['-O3'],
646 }],
647 ]
634 }], 648 }],
635 ['OS=="android"', { 649 ['OS=="android"', {
636 'cflags!': [ 650 'cflags!': [
637 '-O3', 651 '-O3',
638 '-Os', 652 '-Os',
639 ], 653 ],
640 'cflags': [ 654 'cflags': [
641 '-fdata-sections', 655 '-fdata-sections',
642 '-ffunction-sections', 656 '-ffunction-sections',
643 '-O2', 657 '-O2',
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 'OptimizeReferences': '2', 701 'OptimizeReferences': '2',
688 'EnableCOMDATFolding': '2', 702 'EnableCOMDATFolding': '2',
689 }, 703 },
690 }, 704 },
691 }], # OS=="win" 705 }], # OS=="win"
692 ], # conditions 706 ], # conditions
693 }, # Release 707 }, # Release
694 }, # configurations 708 }, # configurations
695 }, # target_defaults 709 }, # target_defaults
696 } 710 }
OLDNEW
« no previous file with comments | « no previous file | src/effects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698