Fix a bug where read-only volumes were recognized as read-write.

chromeos/disks/disk_mount_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
@@ skipping 685 matching lines @@
       chromeos::MOUNT_ERROR_NONE, kSourcePath2, chromeos::MOUNT_TYPE_DEVICE,
       kMountPath2);
 
   const DiskMountManager::DiskMap& disks = manager->disks();
   ASSERT_GT(disks.count(kSourcePath1), 0U);
   EXPECT_FALSE(disks.find(kSourcePath1)->second->is_read_only());
   ASSERT_GT(disks.count(kSourcePath2), 0U);
   EXPECT_TRUE(disks.find(kSourcePath2)->second->is_read_only());
 }
 
+TEST_F(DiskMountManagerTest, MountPath_ReadOnlyDevice) {
+  DiskMountManager* manager = DiskMountManager::GetInstance();
+  const std::string kSourceFormat = std::string();
+  const std::string kMountLabel = std::string();  // N/A for MOUNT_TYPE_DEVICE
+
+  // Event handlers of observers should be called.
+  EXPECT_CALL(
+      observer_,
+      OnMountEvent(DiskMountManager::MOUNTING, chromeos::MOUNT_ERROR_NONE,
+                   Field(&DiskMountManager::MountPointInfo::mount_path,
+                         kReadOnlyMountpath)));
+
+  // Attempt to mount a read-only device in read-write mode.
+  manager->MountPath(kReadOnlyDeviceSource, kSourceFormat, std::string(),
+                     chromeos::MOUNT_TYPE_DEVICE,
+                     chromeos::MOUNT_ACCESS_MODE_READ_WRITE);
+  // Simulate cros_disks reporting mount completed.
+  fake_cros_disks_client_->SendMountCompletedEvent(
+      chromeos::MOUNT_ERROR_NONE, kReadOnlyDeviceSource,
+      chromeos::MOUNT_TYPE_DEVICE, kReadOnlyMountpath);
+
+  const DiskMountManager::DiskMap& disks = manager->disks();
+  ASSERT_GT(disks.count(kReadOnlyDeviceSource), 0U);
+  // The mounted disk should preserve the read-only flag of the block device.
+  EXPECT_TRUE(disks.find(kReadOnlyDeviceSource)->second->is_read_only());
+}
+
 }  // namespace