Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2311793003: Fix UMA logging for net::BidirectionalStream (Closed)

Created:
4 years, 3 months ago by xunjieli
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix UMA logging for net::BidirectionalStream The CL fixes the UMA to use suffixes correctly. See crbug.com/643573 for more info. BUG=635548, 643573 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2311433002 Cr-Commit-Position: refs/heads/master@{#416359} (cherry picked from commit eef1d9c826ac10c339518a86d47dfdcf8da7cec0)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M net/http/bidirectional_stream.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
xunjieli
Hi asvitkine@ and mef@: This is to merge the fix into M54. PTAL. Thanks!
4 years, 3 months ago (2016-09-05 23:39:33 UTC) #7
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-09-06 14:49:57 UTC) #9
mef
lgtm
4 years, 3 months ago (2016-09-06 14:52:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311793003/1
4 years, 3 months ago (2016-09-06 14:54:10 UTC) #12
xunjieli
Thanks! (I requested merge approval on the old bug 635548. I didn't do it on ...
4 years, 3 months ago (2016-09-06 14:55:25 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 14:57:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698